Controllers not extending yieldTemplates

[FredericoC]

I have the following (Coffescript):

Router.configure
  layoutTemplate: 'layout'
  notFoundTemplate: 'notFound'
  loadingTemplate: 'layoutLoading'

  yieldTemplates:
    layoutMasthead: {to: 'mastHeader'}
    uploadQueue: {to: 'uploadQueue'}
    layoutFooter: {to: 'footer'}

@GPRouteController = RouteController.extend
  customLoading: ->
    if @ready()
      NProgress.done()
    else
      NProgress.start()
      @stop()

ProjectController = GPRouteController.extend
  yieldTemplates:
    projectHeaderNav: {to: 'header'}

  projectExists: ->
    unless gp.Permission.canViewProject(Meteor.userId(), @params.projectId)
      @redirect('projects.forbidden')
      @stop()

  before: [
    ->
      @subscribe("project", @params.projectId).wait()
      @subscribe("project.externalShared.user.list", @params.projectId).wait()
    ->
      @customLoading()
    ->
      @projectExists()
    ->
      Session.set('projectId', @params.projectId)
  ]

  @route 'projects.plans',
    path: '/projects/:projectId/plans'
    template: 'plans'
    controller: ProjectPlansController

The "before" hooks extend perfectly, but the "yieldTemplates" property does not. If i use Coffescript native inheritance it will just throw and exception with "before" not defined (I can get the actual error if you want). If I define "projectHeaderNav: {to: 'header'}" in "Router.configure" it works fine.

Any ideas?

[th0r]

@FredericoC, I think issue #150 is about the same. You can check out my comment there.

[cmather]

What's happening here is your Router level config is overriding the RouteController prototype property. It's a bit of a confusing paradigm and maybe we should change it.

In general, options override prototype properties in iron-router. For example:

Controller = function (options) {
  // if we got a value for yieldTemplates from options just use that, otherwise use whatever is currently attached to 'this'
  this.yieldTemplates = options.yieldTemplates || this.yieldTemplates;
};

Controller.prototype.yieldTemplates = {};

So when you globally configure properties on the Router, we pass those along as options to the RouteController. So it's not really inheriting, it's just being passed as an option which is completely overriding the prototype property.

It's possible allowing this behavior was a mistake :-). If you're using RouteControllers I would not use global router config at all (except for autoRender and autoStart etc). Instead, create a super controller and just inherit from that.

ApplicationController = RouteController.extend({
  yieldTemplates: {}
});

ChildController = ApplicationController.extend({
  // inherits yield templates
});

[wbashir]

@cmather Is this still true with how the RouteController works. I tried creating as you mentioned in you're last example, a super controller but my data option is being overriden:

ApplicationController = RouteController.extend({
     data: function(){
          return {
                 user: Meteor.user()   
        }     
}
});

ChildController = ApplicationController.extend({
  data: function(){
        return {
               // I expected to inherit Meteor.User ?????
               someData: {}
        }
}
});

[wbashir]

@cmather Still having this issue