Fix many pylint warnings in healthcheck.py #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, long lines, space between function name and arguments.
pylint complains about too many branches and statements. Unfortunately, there is little we can do about that. The number of statements in the `loop()` function is high because it should be a module of its own but we want to use a single-contained script which is incompatible with a module. Internal functions are used to looks like a module but pylint doesn't care. The too many branches is here because this is how a finite-state automaton should be implemented in Python. The automaton is too simple to warrant the use of distinct functions for each state.
|
|
|
|
|
|
thomas-mangin
added a commit
that referenced
this pull request
May 11, 2015
Fix many pylint warnings in healthcheck.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most warnings are fixed. However, some of them are still here:
loggeris a constant and should be upper-cased. I don't agree with that. I could have imported it from another module (from exabgp.logging import logger) and it would be fine. It is declared at the top level because this is the root logger of the application.