Chore/sof 6429 #41
Closed
Chore/sof 6429 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Object[]} nodes - Array of nodes (e.g. `[tree]` or `node.children`) | ||
| * @returns {{}|{dependencies: {}}} | ||
| */ | ||
| export function buildDependenciesOneOf(nodes) { |
There was a problem hiding this comment.
Should we move this to a file named tree.js?
There was a problem hiding this comment.
It makes use of a tree structure, yes, but the result of this function is really only useful in the context of schemas. In my opinion, it is already in a good place.
tests/utils.schemas.tests.js
Outdated
| modifyProperties: true, | ||
| useEnum: false, | ||
| }); | ||
| // console.log(JSON.stringify(rjsfSchema, null, 4)); |
| value: "data.functional.slug", | ||
| name: "data.functional.name", | ||
| value: "data.functional.enum[0]", | ||
| name: "data.functional.title", |
There was a problem hiding this comment.
Per our discussion:
- Let's add type to know whether we are dealing with a string or object for enum[0] use
- When object, we can have
value: data.functional,name: data.functional.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns the addition of a second function to generate the
dependenciesblock using"oneOf"instead of"enum".