Chore/sof 6463 #45
Merged
Chore/sof 6463 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Array<{path: string}|{regex: RegExp}>} filterObjects - Filter conditions | ||
| * @return {boolean} | ||
| */ | ||
| function isMultiPathSupported(pathObject, multiPathSeparator, filterObjects) { |
There was a problem hiding this comment.
Maybe use npm https://www.npmjs.com/package/path
src/utils/filter.js
Outdated
| */ | ||
| function isPathSupported(pathObject, filterObjects) { | ||
| return ( | ||
| lodash.find(filterObjects, (filterObj) => { |
There was a problem hiding this comment.
Nit, but: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some could also work
timurbazhirov
approved these changes
May 31, 2023
unsigned6
reviewed
Jun 1, 2023
src/utils/filter.js
Outdated
| */ | ||
| function isMultiPathSupported(pathObject, multiPathSeparator, filterObjects) { | ||
| const expandedPaths = pathObject.path.split(multiPathSeparator).map((p) => ({ path: p })); | ||
| return lodash.every(expandedPaths, (obj) => isPathSupported(obj, filterObjects)); |
There was a problem hiding this comment.
Could be done without lodash (few lines but the same with JS only):
for (const expandedPath of expandedPaths) {
if(!isPathSupported(expandedPath, filterObjects) return false;
}
retrun true; There was a problem hiding this comment.
I used the following now, avoiding lodash and explicit for loops:
return expandedPaths.every((expandedPath) => isPathSupported(expandedPath, filterObjects));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns: