CME boot crash

[ukmcplyr]

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my bug.

Platform.

Forge

Minecraft version.

1.19.2

Croptopia version.

2.2.2

What happened?

I've hit the following crash a few dozen times whilst putting a modpack together:

[05:03:45] [modloading-worker-0/ERROR]: Exception caught during firing event: null
        Index: 1
        Listeners:
                0: NORMAL
                1: net.minecraftforge.eventbus.EventBus$$Lambda$4659/0x000000080192f7f0@69771fde
java.util.ConcurrentModificationException
[...]
[05:03:47] [Render thread/ERROR]: Reported exception thrown!
net.minecraft.ReportedException: Rendering overlay
[...]
Caused by: java.util.ConcurrentModificationException
        at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) ~[?:?]
        at java.util.HashMap$ValueIterator.next(HashMap.java:1625) ~[?:?]
        at com.google.common.collect.AbstractMapBasedMultimap.clear(AbstractMapBasedMultimap.java:275) ~[guava-31.0.1-jre.jar%23112!/:?]
        at com.google.common.collect.HashMultimap.clear(HashMultimap.java:51) ~[guava-31.0.1-jre.jar%23112!/:?]
        at com.epherical.croptopia.config.Config.initConfig(Config.java:60) ~[Croptopia-1.19.2-FORGE-2.2.2.jar%23588!/:2.2.2]
[...]

Log and crash report from a few days ago though I've hit the same CME maybe half a dozen times in the past few hours whilst chasing another bug, so it's quite easily reproducible here at least.

Relevant logs

• latest.log
• crash report

Additional information

No response

[ExcessiveAmountsOfZombies]

oh fun, not even sure what would cause this.

[ukmcplyr]

I can try and repro with a more minimal instance in case it's some kind of mod interaction bug. Pretty sure I hit it at least once last night with a mod set of just ~60 mods.

[embeddedt]

Just encountered this in the ATM9 modpack. I'm wondering if it's possible under rare circumstances for Forge to send ModConfigEvent twice on different threads. This could cause one event handler to run features.clear() and the other to be running features.put at the same time.

[ukmcplyr]

Eep, completely forgot about this.

I know practically zero about low-level forge/java but more than happy to test anything should a fix come about. I have the modpack where I was able to hit this frequently archived away just in case.

[embeddedt]

In that case I'd be curious to hear if you can reproduce it at all when https://legacy.curseforge.com/minecraft/mc-mods/modernfix/files/4599348 is installed (I linked this specifically as I only added the potential fix in the latest version for each MC version).

[ukmcplyr]

In that case I'd be curious to hear if you can reproduce it at all when https://legacy.curseforge.com/minecraft/mc-mods/modernfix/files/4599348 is installed (I linked this specifically as I only added the potential fix in the latest version for each MC version).

So far so good! Without modernfix-forge-5.0.4+mc1.19.2.jar, I hit the CME straight away. With it, it's survived a dozen clean boots all the way to the first client tick.

[embeddedt]

Excellent, I was pretty sure that would fix the issue but it was coded blindly as I couldn't get it to ever happen again on my system. 😆

[ukmcplyr]

Glad I kept the pack instance around now, came very close to deleting it a few weeks ago 😁

And thanks for the fix! 🍺