Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify CEX assets #111

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Verify CEX assets #111

merged 5 commits into from
Oct 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2020

#99

@ghost ghost requested a review from raladev October 5, 2020 13:53
@ghost ghost self-assigned this Oct 6, 2020
@ghost ghost force-pushed the feat/verify-assets branch from f27b519 to c44af62 Compare October 6, 2020 13:21
@raladev
Copy link
Contributor

raladev commented Oct 6, 2020

  • no error throwing for unexisted pair if two assets are exist on centralized exchange

Steps:

  1. binance has BTC/DAI pair, but not DAI/BTC
  2. bash xud.sh -b arby --arby.disabled false --arby.live-cex false --arby.base-asset DAI --arby.quote-asset BTC --arby.cex Binance
CEX_BASEASSET: DAI
CEX_QUOTEASSET: BTC
TEST_CENTRALIZED_EXCHANGE_BASEASSET_BALANCE: 123
TEST_CENTRALIZED_EXCHANGE_QUOTEASSET_BALANCE: 321
2020-10-06 01:38:59.5959 [Centralized] info: Base asset balance 0.00842727 and quote asset balance 0.00040029
2020-10-06 01:38:59.5959 [OpenDEX] trace: Base asset balance 709.921875 (maxinbound: 548.828125, maxoutbound: 709.921875) and quote asset balance 2.5 (maxinbound: 2.4499095, maxoutbound: 2.45).
2020-10-06 01:39:00.000 [Centralized] trace: DAIBTC established connection to wss://stream.binance.com:9443/ws/daibtc@aggTrade
2020-10-06 01:39:00.000 [Centralized] trace: heartbeat from DAIBTC socket
2020-10-06 01:39:30.3030 [OpenDEX] trace: Base asset balance 709.921875 (maxinbound: 548.828125, maxoutbound: 709.921875) and quote asset balance 2.5 (maxinbound: 2.4499095, maxoutbound: 2.45).

@ghost
Copy link
Author

ghost commented Oct 7, 2020

* no error throwing for unexisted pair if two assets are exist on centralized exchange

Should be fixed now. The issue was that on the API level the trading pair existed, but was marked as inactive.

@raladev raladev merged commit 27f456f into master Oct 7, 2020
@ghost ghost deleted the feat/verify-assets branch October 7, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant