Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webproxy streaming support #137

Closed
moshababo opened this issue Jun 19, 2018 · 13 comments
Closed

webproxy streaming support #137

moshababo opened this issue Jun 19, 2018 · 13 comments
Labels
enhancement New feature or request grpc gRPC API
Milestone

Comments

@moshababo
Copy link
Collaborator

#128 is a prerequisite.

@moshababo moshababo added enhancement New feature or request grpc gRPC API 26-50 XUC labels Jun 19, 2018
@moshababo moshababo added this to the 1.0.0-beta milestone Jun 19, 2018
@moshababo
Copy link
Collaborator Author

This can be implemented now.

@fundrequestbot
Copy link


This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #137

  • For more help on how to claim on issue, please visit our help section.
  • Looking for more? Feel free to browse through all funded requests.

@rsercano
Copy link
Collaborator

Hello @moshababo I'm interested in this issue, would you please explain more ?

@moshababo
Copy link
Collaborator Author

Hi, @rsercano, good to see you here.
We're using gRPC to expose our high-level API. gRPC server doesn't support browser clients, so we added a web proxy layer to expose all the methods via simple HTTP endpoints (at the moment it's disabled by default). It supports simple request-response calls, but not calls which use server-side streaming. We created one streaming call so far (#144), that can be used for testing purposes.

@rsercano
Copy link
Collaborator

rsercano commented Jul 11, 2018

Therefore, we need it to support streaming on web proxy layer ?

p.s. swagger doesn't work while using "Try it Out" button, it tries to send URLs without /api in it :)

@moshababo
Copy link
Collaborator Author

Yes, or some kind of polling mechanism.

Haven't got a chance to try the swagger yet. Feel free to open a bug.

@itsbalamurali
Copy link
Contributor

@rsercano @moshababo http long polling can also be an option.

@kilrau
Copy link
Contributor

kilrau commented Oct 27, 2018

Just stumbled upon this project, which seems well maintained and got streaming rpc's included. We might be able to use some stuff. Realistic you'll have time to take care of this in the next weeks? @rsercano

@kilrau kilrau modified the milestones: 1.0.0-alpha.3, 1.0.0-alpha.4 Oct 27, 2018
@sangaman
Copy link
Collaborator

Looks cool, if I'm reading that right we could drop our need for a web proxy entirely?

@kilrau
Copy link
Contributor

kilrau commented Oct 29, 2018

Open question @moshababo

@moshababo
Copy link
Collaborator Author

@kilrau we looked at this project in the beginning. the streaming web proxy support is a stand-alone Go project. We wanted to have it as a native feature in our JS project instead.
Before implementing, we should definitely look on their Go implementation.

@sangaman
Copy link
Collaborator

Oh I think that's right and I just had amnesia. Maybe first lets see how easy it is to handle streaming calls with our current approach, for all I know it might work already, I just haven't tried it yet.

@kilrau kilrau modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.7 Nov 18, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.10, 1.0.0 Feb 20, 2019
@kilrau kilrau removed the 26-50 XUC label Apr 11, 2019
@kilrau
Copy link
Contributor

kilrau commented Apr 11, 2019

Since the main usage of the webproxy will be raiden and raiden doesn't seem to have streams, I am closing this. We can open a new issue once we have a concrete need for streaming for the webproxy. Please reopen if you object, but we'd need some details on what we need it for. @sangaman @moshababo

@kilrau kilrau closed this as completed Apr 11, 2019
@kilrau kilrau mentioned this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grpc gRPC API
Projects
None yet
Development

No branches or pull requests

6 participants