Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing button backgrounds and text #78

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Apr 27, 2020

This prototypes removing button backgrounds and text (text now shows on hover). What do people think about it? cc @AakashGfude @jstac @najuzilu @chrisjsewell

2020-04-27_14-57-03

@choldgraf
Copy link
Member Author

I think that it looks cleaner - if folks don't think that removing the text is a problem, then I'd be +1 on merging this and iterating from there...

@AakashGfude
Copy link
Member

+1 on this. It looks neat. I also think that those tooltip texts download this page and launch interactive content might be a bit obtrusive for the dropdown and we can do without it?

@jstac
Copy link
Member

jstac commented Apr 28, 2020

Yes, it looks much cleaner. Nice one. Without text there's less distraction from the heading.

@chrisjsewell also suggested right aligned and that sounds good too --- but either way I agree on making this change and then iterating.

@choldgraf
Copy link
Member Author

let's merge this one and then we can iterate on right-aligned in another issue. I want to leave the tooltips for now, partially because they're a bit more accessibility-friendly. Thanks for the feedback!

@choldgraf choldgraf merged commit a5df5a9 into executablebooks:master Apr 28, 2020
@choldgraf choldgraf deleted the button_background branch April 28, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants