Log overall response message when using PRDR #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomis
force-pushed
the
prdr-log-overall-response
branch
from
6ffe31b
to
de65081
Compare
When using PRDR, the "C=" log message only contains the PRDR response and the overall response message (that typically contains the remote message reference) is not logged. The logged response is already capable of containing multiple lines in the event that there is a multi-line response, so this change appends the overall response to the PRDR response with a newline between them. The "C=" log message will therefore contain both responses: => ... PRDR C="250 PRDR R=<postmaster@example.com> acceptance\\n250 id=1eiQ9X-0005Ra-I3 message accepted" QT=3s DT=0s -> ... PRDR C="250 PRDR R=<postmaster@example.net> acceptance\\n250 id=1eiQ9X-0005Ra-I3 message accepted" QT=3s DT=0s
nomis
force-pushed
the
prdr-log-overall-response
branch
from
de65081
to
88192db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PRDR, the "C=" log message only contains the PRDR response
and the overall response message (that typically contains the remote
message reference) is not logged.
The logged response is already capable of containing multiple lines
in the event that there is a multi-line response, so this change
appends the overall response to the PRDR response with a newline
between them.
The "C=" log message will therefore contain both responses:
=> ... PRDR C="250 PRDR R=postmaster@example.com acceptance\n250 id=1eiQ9X-0005Ra-I3 message accepted" QT=3s DT=0s
-> ... PRDR C="250 PRDR R=postmaster@example.net acceptance\n250 id=1eiQ9X-0005Ra-I3 message accepted" QT=3s DT=0s