-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertion failure in crwimage_int.cpp #1739
Fix assertion failure in crwimage_int.cpp #1739
Conversation
I'm not 100% sure what the best solution is, tbh. WDYT @kevinbackhouse ? |
3d3ed4f
to
c79d83f
Compare
@hassec: I think I found a better solution. I recently discovered that we have a macro called |
Thanks for pointing that out, didn't know about that part yet, but it sounds like a great solution. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! 👍
Fixes GHSA-mv9g-fxh2-m49m.
A malicious file can cause an assertion failure in
packIfdId
. It happens during printing, so I thought it would be best to ignore the error and keep going, rather than throw an exception. Let me know if you think it would be better to throw an exception instead. I also added a debug message, which is printed tostderr
whenEXIV2_DEBUG_MESSAGES
is enabled.