Fix assertion failure in crwimage_int.cpp #1739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GHSA-mv9g-fxh2-m49m.
A malicious file can cause an assertion failure in
packIfdId. It happens during printing, so I thought it would be best to ignore the error and keep going, rather than throw an exception. Let me know if you think it would be better to throw an exception instead. I also added a debug message, which is printed tostderrwhenEXIV2_DEBUG_MESSAGESis enabled.