Fix assertion failure in crwimage_int.cpp

[kevinbackhouse]

Fixes GHSA-mv9g-fxh2-m49m.

A malicious file can cause an assertion failure in packIfdId. It happens during printing, so I thought it would be best to ignore the error and keep going, rather than throw an exception. Let me know if you think it would be better to throw an exception instead. I also added a debug message, which is printed to stderr when EXIV2_DEBUG_MESSAGES is enabled.

[hassec]

I'm not 100% sure what the best solution is, tbh.
To me, it would make sense to inform the user of the fact that something is wrong with the file by either throwing an error or printing a warning.

WDYT @kevinbackhouse ?

[kevinbackhouse]

@hassec: I think I found a better solution. I recently discovered that we have a macro called EXV_ERROR that's good for this. You can silence it by putting -q on the command line.

[hassec]

Thanks for pointing that out, didn't know about that part yet, but it sounds like a great solution. 👍

[hassec]

Thanks for fixing this! 👍