makernotes: workaround for Olympus header corruption

[kmilos]

Addresses #2542 as a workaround rather than a proper solution.

Should be able to parse the data back, but still leaves a "corrupted" file that other apps might have trouble with...

@tenzap I think this should also apply to 0.27 branch (w/ maybe some minimal tweaks), so please feel free to test.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2567 (0f31c85) into main (0fa22ed) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   63.90%   63.89%   -0.02%     
==========================================
  Files         103      103              
  Lines       22393    22397       +4     
  Branches    10824    10826       +2     
==========================================
  Hits        14310    14310              
- Misses       5864     5867       +3     
- Partials     2219     2220       +1     

Impacted Files	Coverage Δ
src/makernote_int.cpp	65.85% <0.00%> (-0.50%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kmilos]

Is there an appetite to backport for a 0.27.7 hotfix (w/ maybe a few more select cherry-picks)? @nehaljwani @kevinbackhouse @piponazo @postscript-dev @hassec

[kevinbackhouse]

Is there an appetite to backport for a 0.27.7 hotfix (w/ maybe a few more select cherry-picks)? @nehaljwani @kevinbackhouse @piponazo @postscript-dev @hassec

Yes, that makes sense. My understanding from quickly reading #2542 is that this was a regression from 0.27.5 to 0.27.6.

[kmilos]

Not a regression per se, as the feature responsible for the bug wasn't there in 0.27.5 at all.

[nehaljwani]

Feel free to open a pull request for the 0.27-maintenance branch and I'll cut a release after it is merged.

[kmilos]

Great, can you please create a 0.27.7 milestone then as well?

Any other changes we might want to backport? @kevinbackhouse @piponazo @postscript-dev @hassec

[nehaljwani]

@kmilos Is now a good time to cut a release with the backports?

[kmilos]

@nehaljwani Sure, thanks!

[nehaljwani]

Exiv2 v0.27.7 2023-05-14

Topic	More Info
Remaining ( 0)	https://github.com/Exiv2/exiv2/milestone/11
Completed (3)	https://github.com/Exiv2/exiv2/milestone/11?closed=1

Exiv2 v0.27.7 Acknowledgements

According to git shortlog -s -n v0.27.6..v0.27.7

Commits	Author
8	Miloš Komarčević
2	Peter Kovář
1	Nehal J Wani

Exiv2 v0.27.7 Release Notes

Group	PR	Topic	Issue
Bugs & Fixes	#2579	makernotes: workaround for Olympus header corruption	#2542
	#2578	Corrected JPEG XL file type
	#2614	BMFF: fix handling of boxes w/ zero length or type	darktable-org/darktable#14473
CI	#2604	CI: Bump conan version

If I've failed to acknowledge anyone's contribution, I apologize. Please let me know and I'll update this comment.