Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makernotes: workaround for Olympus header corruption (backport #2567) #2579

Merged
merged 3 commits into from Apr 17, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Apr 4, 2023

No description provided.

@kmilos kmilos added the makerNote Anything related to one of the various supported MakerNote formats label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2579 (04d3a7c) into 0.27-maintenance (c60285e) will decrease coverage by 1.11%.
The diff coverage is 0.00%.

❗ Current head 04d3a7c differs from pull request most recent head aa10013. Consider uploading reports for the commit aa10013 to get more accurate results

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2579      +/-   ##
====================================================
- Coverage             59.92%   58.81%   -1.11%     
====================================================
  Files                   149      149              
  Lines                 23921    24474     +553     
  Branches              12664    12667       +3     
====================================================
+ Hits                  14334    14395      +61     
- Misses                 6692     7210     +518     
+ Partials               2895     2869      -26     
Impacted Files Coverage Δ
src/makernote_int.cpp 68.73% <0.00%> (-1.13%) ⬇️

... and 99 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmilos kmilos added this to In Progress in Exiv2 v0.27 dot releases Apr 4, 2023
@kmilos kmilos added this to the v0.27.7 milestone Apr 5, 2023
@kevinbackhouse
Copy link
Collaborator

Is there a test image for this, so that we can fix the code coverage?

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 7, 2023

See #2542 for constructing this error state, not quite sure how to set up the test just yet...

@kmilos kmilos merged commit d6ea2a8 into 0.27-maintenance Apr 17, 2023
33 checks passed
Exiv2 v0.27 dot releases automation moved this from In Progress to Done Apr 17, 2023
@mergify mergify bot deleted the bp_pr-2567 branch April 17, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
makerNote Anything related to one of the various supported MakerNote formats
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants