Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverity fixes #2696

Merged
merged 1 commit into from
Jul 17, 2023
Merged

coverity fixes #2696

merged 1 commit into from
Jul 17, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 17, 2023

No description provided.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ghost
Copy link

ghost commented Jul 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2696 (ac6443e) into main (7473b4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2696   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22314    22312    -2     
  Branches    10800    10799    -1     
=======================================
- Hits        14261    14260    -1     
  Misses       5828     5828           
+ Partials     2225     2224    -1     
Impacted Files Coverage Δ
src/xmp.cpp 75.94% <ø> (ø)
src/basicio.cpp 50.52% <100.00%> (+<0.01%) ⬆️
src/image.cpp 70.19% <100.00%> (ø)
src/value.cpp 72.42% <100.00%> (ø)

Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit d4f6c9c into Exiv2:main Jul 17, 2023
105 checks passed
@neheb neheb deleted the cov branch July 17, 2023 17:01
@neheb
Copy link
Collaborator Author

neheb commented May 22, 2024

@Mergifyio backport 0.28.x

Copy link
Contributor

mergify bot commented May 22, 2024

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants