-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 0.28.3 #3008
Comments
Output of
That's @kmilos @neheb @enen92 @ferdnyc @norbertwg @hassec @jim-easterbrook @kevinbackhouse @lbschenkel @wmanth @bertwim |
+1 |
By the way, the release notes will link to this issue, so if there are any bugfixes or new features that you'd like to highlight, please do it by adding a comment here. |
I think everything's ready. Any objections to me publishing the release on 2024-07-08 (Monday)? |
I don't know what query/command is being used to generate this, or if there's an easy solution, but it seems like every commit from a contributor PR is being attributed to @mergify. I probably won't shock anyone when I say that none of those commits were actually contributed by the Mergify bot. 😀 Not a huge deal, but it makes the changelog attributions sort of pointless. Almost better to leave them out entirely, I'd argue, than listing @mergify for everything. (Edit: By which I mean, leave out just the author tags, not the commits themselves.) |
When I created the release, this was the auto-generated comment. I didn't like it much either, so I decided to paste it into a comment here instead. A lot of the PRs on the 0.28.x branch are created by the @mergify app because we use it to backport PRs from the main branch. |
*nod* And I eventually realized that the changelog was listing PRs (and their owners), rather than actual commits and their authors. Which... I can see arguments for and against, TBH.
Oh, auto-generated by GitHub? Well, I suppose it makes sense that they'd choose PRs as the ChangeLog granularity, at least. Shame that it clashes so severely with the Mergify process (or any process) for building release branches via backport PRs. |
Let's release version 0.28.3 so that we can ship these two bugfixes:
The text was updated successfully, but these errors were encountered: