Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.28.3 #3008

Closed
kevinbackhouse opened this issue Jul 4, 2024 · 10 comments · Fixed by #3009
Closed

Release version 0.28.3 #3008

kevinbackhouse opened this issue Jul 4, 2024 · 10 comments · Fixed by #3009
Assignees
Labels
Milestone

Comments

@kevinbackhouse
Copy link
Collaborator

Let's release version 0.28.3 so that we can ship these two bugfixes:

@kevinbackhouse kevinbackhouse added this to the v0.28.3 milestone Jul 4, 2024
@kevinbackhouse kevinbackhouse linked a pull request Jul 4, 2024 that will close this issue
@kevinbackhouse
Copy link
Collaborator Author

Output of git shortlog -s -n v0.28.2..0.28.x:

    11  Miloš Komarčević
    10  Rosen Penev
     3  Miguel Borges de Freitas
     2  FeRD (Frank Dana)
     2  enen92
     2  norbertwg
     1  Christoph Hasse
     1  Jim Easterbrook
     1  Kevin Backhouse
     1  Leonardo Brondani Schenkel
     1  Wolfram Manthey
     1  bwvb

That's @kmilos @neheb @enen92 @ferdnyc @norbertwg @hassec @jim-easterbrook @kevinbackhouse @lbschenkel @wmanth @bertwim

@enen92
Copy link
Contributor

enen92 commented Jul 4, 2024

+1
Thanks for the announcement. Will allow us to drop pretty much all patches that we have on top of the previous version.

@kevinbackhouse
Copy link
Collaborator Author

By the way, the release notes will link to this issue, so if there are any bugfixes or new features that you'd like to highlight, please do it by adding a comment here.

@kmilos
Copy link
Collaborator

kmilos commented Jul 5, 2024

@kevinbackhouse kevinbackhouse self-assigned this Jul 5, 2024
@kevinbackhouse
Copy link
Collaborator Author

I think everything's ready. Any objections to me publishing the release on 2024-07-08 (Monday)?

@kevinbackhouse
Copy link
Collaborator Author

What's Changed

Full Changelog: v0.28.2...v0.28.3

@kevinbackhouse
Copy link
Collaborator Author

@ferdnyc
Copy link
Contributor

ferdnyc commented Jul 8, 2024

What's Changed

[...]

I don't know what query/command is being used to generate this, or if there's an easy solution, but it seems like every commit from a contributor PR is being attributed to @mergify. I probably won't shock anyone when I say that none of those commits were actually contributed by the Mergify bot. 😀

Not a huge deal, but it makes the changelog attributions sort of pointless. Almost better to leave them out entirely, I'd argue, than listing @mergify for everything.

(Edit: By which I mean, leave out just the author tags, not the commits themselves.)

@kevinbackhouse
Copy link
Collaborator Author

kevinbackhouse commented Jul 8, 2024

I don't know what query/command is being used to generate this, or if there's an easy solution, but it seems like every commit from a contributor PR is being attributed to @mergify. I probably won't shock anyone when I say that none of those commits were actually contributed by the Mergify bot. 😀

Not a huge deal, but it makes the changelog attributions sort of pointless. Almost better to leave them out entirely, I'd argue, than listing @mergify for everything.

When I created the release, this was the auto-generated comment. I didn't like it much either, so I decided to paste it into a comment here instead.

A lot of the PRs on the 0.28.x branch are created by the @mergify app because we use it to backport PRs from the main branch.

Image

@ferdnyc
Copy link
Contributor

ferdnyc commented Jul 9, 2024

@kevinbackhouse

A lot of the PRs on the 0.28.x branch are created by the @mergify app because we use it to backport PRs from the main branch.

*nod* And I eventually realized that the changelog was listing PRs (and their owners), rather than actual commits and their authors.

Which... I can see arguments for and against, TBH.

When I created the release, this was the auto-generated comment.

Oh, auto-generated by GitHub? Well, I suppose it makes sense that they'd choose PRs as the ChangeLog granularity, at least. Shame that it clashes so severely with the Mergify process (or any process) for building release branches via backport PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants