Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: do not hardcode ENOENT (backport #2700) #2702

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 18, 2023

This is an automatic backport of pull request #2700 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The actual values of errno constants are not specified in POSIX, and
left as implementation details; hence, tweak the check for the ENOENT
description to not check for the actual value.

(cherry picked from commit 7f99757)
@mergify mergify bot mentioned this pull request Jul 18, 2023
@kmilos kmilos added platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc testing Anything related to the tests and their infrastructure labels Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2702 (3edbe50) into 0.28.x (414bff1) will decrease coverage by 0.01%.
The diff coverage is 34.28%.

@@            Coverage Diff             @@
##           0.28.x    #2702      +/-   ##
==========================================
- Coverage   63.92%   63.92%   -0.01%     
==========================================
  Files         103      103              
  Lines       22306    22310       +4     
  Branches    10796    10796              
==========================================
+ Hits        14259    14261       +2     
  Misses       5827     5827              
- Partials     2220     2222       +2     
Impacted Files Coverage Δ
include/exiv2/image.hpp 100.00% <ø> (ø)
include/exiv2/matroskavideo.hpp 60.00% <ø> (ø)
include/exiv2/slice.hpp 90.56% <ø> (ø)
include/exiv2/value.hpp 85.11% <ø> (ø)
src/basicio.cpp 50.52% <0.00%> (ø)
src/canonmn_int.cpp 72.88% <ø> (ø)
src/nikonmn_int.cpp 61.20% <0.00%> (ø)
src/panasonicmn_int.cpp 52.58% <ø> (ø)
src/quicktimevideo.cpp 60.14% <0.00%> (ø)
src/rafimage.cpp 20.29% <ø> (ø)
... and 13 more

@kmilos kmilos merged commit 25bc85e into 0.28.x Jul 18, 2023
106 checks passed
@mergify mergify bot deleted the mergify/bp/0.28.x/pr-2700 branch July 18, 2023 11:31
@kevinbackhouse kevinbackhouse added this to the v0.28.1 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc testing Anything related to the tests and their infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants