Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more regex (backport #2897) #2907

Merged
merged 1 commit into from
Jan 26, 2024
Merged

remove more regex (backport #2897) #2907

merged 1 commit into from
Jan 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 25, 2024

This is an automatic backport of pull request #2897 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Rosen Penev <rosenp@gmail.com>
(cherry picked from commit 2d7814b)
@mergify mergify bot mentioned this pull request Jan 25, 2024
@kmilos kmilos added the refactoring Cleanup / Simplify code -> more readable / robust label Jan 25, 2024
@kmilos kmilos added this to the v0.28.2 milestone Jan 25, 2024
@ghost
Copy link

ghost commented Jan 25, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (72129e7) 63.99% compared to head (1eeb4ff) 64.03%.
Report is 30 commits behind head on 0.28.x.

Files Patch % Lines
src/rafimage.cpp 0.00% 6 Missing ⚠️
src/value.cpp 86.36% 0 Missing and 3 partials ⚠️
src/canonmn_int.cpp 83.33% 1 Missing and 1 partial ⚠️
src/datasets.cpp 66.66% 0 Missing and 1 partial ⚠️
src/jp2image.cpp 50.00% 1 Missing ⚠️
src/jpgimage.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.28.x    #2907      +/-   ##
==========================================
+ Coverage   63.99%   64.03%   +0.03%     
==========================================
  Files         103      104       +1     
  Lines       22338    22371      +33     
  Branches    10821    10834      +13     
==========================================
+ Hits        14296    14325      +29     
- Misses       5818     5820       +2     
- Partials     2224     2226       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos kmilos requested a review from neheb January 25, 2024 09:39
@neheb neheb merged commit 002405d into 0.28.x Jan 26, 2024
107 of 108 checks passed
@neheb neheb deleted the mergify/bp/0.28.x/pr-2897 branch January 26, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants