Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lens): canon lens detecton should be independent of locale #2938

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

hassec
Copy link
Member

@hassec hassec commented Mar 29, 2024

  • replace std::stof by a locale independent string-> float alternative.
  • Run the lens tests a 2nd time in the CI with a DE locale to protect against regressions. This only protects locale based regressions in the canon lens detection. But exiv2 could probably benefit from a more global test. Something for the exiv2 maintainer team to consider.

Closes #2746

@hassec hassec force-pushed the canon_lens_tests branch 3 times, most recently from 5107f9d to 1f1a995 Compare March 29, 2024 03:13
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.57%. Comparing base (b6e1360) to head (6565352).
Report is 1 commits behind head on main.

Files Patch % Lines
src/canonmn_int.cpp 68.75% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2938   +/-   ##
=======================================
  Coverage   64.57%   64.57%           
=======================================
  Files         104      104           
  Lines       22196    22207   +11     
  Branches    10882    10889    +7     
=======================================
+ Hits        14332    14341    +9     
- Misses       5622     5623    +1     
- Partials     2242     2243    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CMakeLists.txt Show resolved Hide resolved
src/canonmn_int.cpp Show resolved Hide resolved
src/canonmn_int.cpp Show resolved Hide resolved
src/canonmn_int.cpp Show resolved Hide resolved
@kmilos kmilos added bug lens Issue related to lens detection labels Mar 29, 2024
@kmilos kmilos added the i18n Internationalisation label Mar 29, 2024
@kmilos kmilos requested a review from neheb March 29, 2024 14:47
@neheb neheb merged commit eed6aca into Exiv2:main Mar 30, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n Internationalisation lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canon lens handling regression in 0.28.0
3 participants