Deploy Checklist: New Expensify 2022-11-04

[OSBotify]

Release Version: 1.2.24-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• onKeyDown added to Textlink component #12034
• Fix: "Hmm... it's not here" view is showing up with back and dismiss button while the page already has those buttons #12096
• Standardize form error styles #12098
• Correctly display first name for IOU requests #12184
• Fix issue cards options still available after deleting bank account #12279
• Fix #11797 upadte @svgr/webpack to version 6.0.0 #12296
• Fix redbrick path for workspace #12329
• Subscribe report event when report successfully created #12365
• Improve the performance of report name generation #12399
• Add errors object back to menu item, remove unused isPolicy #12460
• Revert PR11313 #12468
• [NO-QA] Resolve upstream ReactNative android build blocker #12510
• [NO-QA] Lock Android Hermes gradle version #12525
• Stop using deprecated jcenter repository for android dependencies #12532
• fix crash on profile detail #12533

Deploy Blockers:

• [HOLD for payment 2022-11-16] [$250] Chat - App is crashed after click on expensifail account which is closed #12487
• Request Money - App is crashed when clicking on a name of the user after request money for new account #12503
• Android build 1.2.24-1 crashes on launch #12522

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[roryabraham]

Love these shorter checklists, let's keep up with daily deploys 🚀

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.24-0 🚀

[mvtglobally]

@roryabraham did Android build go through?

[Julesssss]

@roryabraham did Android build go through?

Nope, but we're currently investigating.

[mvtglobally]

Let us know once the build issue is resolved. Android is the only outstanding item to close out this regression

[Julesssss]

Hi @mvtglobally, we're working on this and you should see an automated message here once it's deployed 🤞

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.24-1 🚀

[mvtglobally]

@Julesssss This new build did not push Android update. We still see 1.2.23-9

[mvtglobally]

@Julesssss We just got the build, but its not working. App is crashing. Need a bug or you guys already aware?

Screen_Recording_20221107-111743_Google.Play.Store.mp4

[Julesssss]

No, that wasn't reproducible during testing. Looking into this now 😕

[Julesssss]

Created an issue here, will keep you updated: #12522

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.24-1 has been deployed to staging 🎉

[Julesssss]

@mvtglobally another fix is incoming 🤞

@yuwenmemon should be able to help with any further issues as I'm signing off now

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.24-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.24-2 has been deployed to staging 🎉

[mvtglobally]

@yuwenmemon Did Android build go through Google? We are not seeing a 1.2.24-2 version yet

[yuwenmemon]

@mvtglobally Unfortunately it did not - we're working on it.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.24-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.24-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.24-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.24-4 has been deployed to staging 🎉

[yuwenmemon]

@mvtglobally We should be good to go now! Sorry for the delay

[mvtglobally]

we are running regression. Should have results in a bit

[mvtglobally]

@yuwenmemon @Julesssss Regression is completed

PR #12034 is blocked on IOS and Android with #12480
PR #12279 is blocked by #11796 on IOS and Android and blocked by #12308 on mWeb and Desktop
PR #12296 is failing #12492. We were not able to repro on PROD, but it seems to be there as well. pls double check
Checking 2 last CPs

[yuwenmemon]

@mvtglobally can we test #12487 and check it off if it passes?

[yuwenmemon]

Checking off #12296 because I was able to reproduce on prod and everything else from that PR works fine.

[mvtglobally]

Asking team to re-test

[yuwenmemon]

Checking off #12034 because it pertains to a non-mobile flow anyway - and #12480 is actively being worked on and also present on prod.

[yuwenmemon]

@mvtglobally any update on how that testing went?

[mvtglobally]

@yuwenmemon We are not able to repro on Web. Checking on other platforms

[yuwenmemon]

Nice, I'm cautiously optimistic then 😄

[mvtglobally]

@yuwenmemon issue is no longer repro across platforms

[yuwenmemon]

Sweet! Can we close and check off that last issue?

[yuwenmemon]