Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-05-16] [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18194

Closed
melvin-bot bot opened this issue Apr 29, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff

Comments

@melvin-bot
Copy link

melvin-bot bot commented Apr 29, 2023

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 880/1000
Why? Mature exploit, Recently disclosed, Has a fix available, CVSS 7.6
Integer Overflow or Wraparound
SNYK-JS-ELECTRON-5462056
No Mature

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e6c354c4810571c
  • Upwork Job ID: 1652318066339057664
  • Last Price Increase: 2023-05-19
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Apr 29, 2023
@MelvinBot
Copy link

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~013e6c354c4810571c

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 29, 2023
@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 9, 2023
@melvin-bot melvin-bot bot changed the title [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 [HOLD for payment 2023-05-16] [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 May 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link
Author

melvin-bot bot commented May 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 18, 2023

@aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label May 18, 2023
@aimane-chnaif
Copy link
Contributor

@stitesExpensify can you please add BZ member for me?

@melvin-bot melvin-bot bot removed the Overdue label May 18, 2023
@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label May 19, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-16] [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 [$1000] [HOLD for payment 2023-05-16] [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 May 19, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@thienlnam
Copy link
Contributor

@tjferriss This issue is ready for payment - internal review to @aimane-chnaif

@melvin-bot melvin-bot bot added the Overdue label May 22, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 22, 2023

@tjferriss, @thienlnam, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam
Copy link
Contributor

Bump when you get the chance @tjferriss

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 23, 2023
@tjferriss
Copy link
Contributor

@aimane-chnaif the offer is pending your acceptance: https://www.upwork.com/jobs/~0168b695076da79b8d.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 26, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 29, 2023

@tjferriss, @thienlnam, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tjferriss
Copy link
Contributor

@aimane-chnaif has been paid.

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants