[PAID] Next button is disabled when trying to invite person to workspace

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Regression from #15672

BUG ‘Next’ button is disabled on back navigation even if there is a selected user; as a result user cannot continue to invite the selected user after navigating back

Action Performed:

Click on ‘Profile’ avatar
Click on ‘Workspaces’ link
Open an existing workspace
Click on ‘Manage members’ link
Click on ‘Invite’ button
Enter email address > select user > click on ‘Next’ button
Click on back navigation icon
Expected Result: Next button shouldn’t be disabled as long as there is a selected user
Actual Result: Next button is disabled even thought there is a selected user

Issue 2
Alluded to by @bondydaa #15672 (comment)

Action Performed:

Log in with account that has access to the policy-expense-chat beta
Go offline by navigating to [profile icon] > Preferences > and enable Force offline
Create a new workspace.
Invite some people to the workspace. Verify that workspace chats for each member appear optimistically.
Go online by navigating to [profile icon] > Preferences > disable Force online.
Expected Result:
Workspace chats created for each members are updated accordingly

Actual Result:

??? Something else ???

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683077956552549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01200c513fe2717ddb
• Upwork Job ID: 1654115698073346048
• Last Price Increase: 2023-05-04

[MelvinBot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01200c513fe2717ddb

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[strepanier03]

Working on this now.

[strepanier03]

For issue 1, I cannot recreate the behavior. On staging it works just fine for me, the Next button doesn't get disabled after clicking the back navigation icon. I'll need to test on Prod too.

---

For issue 2, I'm working on testing this but need to ensure my accounts are part of the beta. Will update once I'm done.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[0xmiros]

@strepanier03 this is already fixed in #18395.
This GH is created just for tracking payment, etc.

[mountiny]

Correct this should be now fixed in staging 🎉

[strepanier03]

Brilliant, then I'll follow along and take payment action when needed.

[mountiny]

@abdulrahuman5196 @0xmiroslav this was a regression from #15672, I believe in this case we should only pay the C+ for help on the PR. Would this be $1000 too as internal PR? I think we can proceed with the payment on this one

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Followup fixes on invite message page implementation #18395

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @Natnael-Guchima - $250
• Contributor that fixed the issue - no contributor assigned
• Contributor+ that helped on the issue and/or PR - @0xmiroslav - $1000

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[strepanier03]

@mountiny -- You're correct, internal issues are paid to the C+ at the flat $1000 rate.

I see that you listed @Natnael-Guchima as the bug reporter in the OP comment and I wanted to confirm they get a bug report bonus of $250 with you since you only mentioned paying the C+. Should I whip up a bug report job for Natnael?

[mountiny]

@strepanier03 correct @Natnael-Guchima should also be paid out $250

[strepanier03]

Gotcha, thank you @mountiny, will take care of setting everything up today.

[strepanier03]

@0xmiroslav - I have hired you to the job in UpWork, please take a look at the BZ checklist and leave any necessary comments and I'll update the OP checklist with your responses.

---

@Natnael-Guchima I've also created and hired you to a bug reporting job, please accept and I'll pay out tomorrow as well.

Thank you both!

[Natnael-Guchima]

@0xmiroslav - I have hired you to the job in UpWork, please take a look at the BZ checklist and leave any necessary comments and I'll update the OP checklist with your responses.

---

@Natnael-Guchima I've also created and hired you to a bug reporting job, please accept and I'll pay out tomorrow as well.

Thank you both!

Accepted! Thanks @strepanier03

[0xmiros]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR: Implement Invite message page #15672
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Implement Invite message page #15672 (comment)
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@0xmiroslav] Determine if we should create a regression test for this bug.: This could have been caught earlier during PR review so no need any other step.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.: N/A

[strepanier03]

Everything is done here, I've finished paying and closing contracts as well as leaving feedback. Thank you all for the diligence and effort 🙌 .