[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] Cursor does not change to I beam on selecting mentions like it does for other clickable links

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send message with mention
4. Click and drag to highlight the message containing the message and observe that cursor remains pointer while highlighting and does not change to I beam

Expected Result:

App should change the cursor to I beam while highlighting the mentions part in message as it normally does for email, links etc

Actual Result:

App keeps the cursor as pointer and does not change to I beam while selecting mentions part in message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

cursor.not.change.to.I.beam.for.mentions.mp4

Recording.658.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684312696564409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017477dd353ae7b577
• Upwork Job ID: 1664022662379630592
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[strepanier03]

I am testing this and the mentions as well as other clickable links, like embedded URLs are all the point, not the I beam.

I believe it should be the point because it's clickable whereas the I beam indicates text and typing.

@kavimuru - Can you weigh in here. I'm not sure about moving this one forward.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

@dhanashree-sawant - I have question about your repro steps. In step 4 you say "Select the mention message and observe that cursor remains pointer while selecting and does not change to I beam".

By "select" do you mean open up the sent message to editing and then clicking on the mention?

The reason I ask is because the pointer makes sense to me because the mention is clickable, just like other links.

If I hyperlink a URL, it should be a pointer because it's clickable, same with the mention.

Can you help me understand why it should be an I beam if it's clickable?

[dhanashree-sawant]

Hi @strepanier03, if you see email, URL, they are all clickable but when we select by dragging over them, cursor changes to I beam, if we want to keep the cursor as pointer while drag and select, we should do that too on email and URL to maintain consistency.

[strepanier03]

Aaah, I think I didn't understand that "select" meant to drag over the message, not click (select) on them. I'll go through it again and update the OP comment with the clarification.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017477dd353ae7b577

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @joelbettner (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[strepanier03]

Okay, I updated repro steps and confirmed following them repros the behavior for me.

I agree we should be consistent and highlighting a message should be I beam and not pointer.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App keeps the cursor as pointer and does not change to I beam while selecting mentions part in message.

What is the root cause of that problem?

In web we only have the behavior of "cursor is different when text is being selected" for text inside <a> tag, with href attribute. That's why we can see the correct behavior for links, emails because they are in <a> tag, with href. The same can be observed for other texts in <a>, for example the text links in login page.

So the problem here is we're not using <a> for the mention-user comment type, but we're expecting it to have the behavior of <a> tag. It should indeed be in <a> tag since it's essentially a link to the user's profile details (Slack also does it too).

What changes do you think we should make in order to solve the problem?

To fix this we simply need to make the Text here a TextLink, and add a proper href to it (the place in our site where we lead the user after they click the mention)

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 40 in 5ff32c3

<Text

This is consistent with the @mention-user feature in Slack too.

Note: we don't need this for @here because @here currently doesn't link to anything and doesn't have the cursor: pointer

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@eVoloshchak @strepanier03 @joelbettner this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[strepanier03]

Little bump on the proposal @eVoloshchak, thank you 🙌

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @eVoloshchak, @joelbettner, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@eVoloshchak Do you mind getting us kicked off with the BZ checklist above ahead of kicking off payouts tomorrow?

[JmillsExpensify]

In the meantime, let's get the payouts catalogued.

• Issue reporter: @dhanashree-sawant $250
• Contributor: @tienifr $1,000
• Contributor+: @eVoloshchak $1,000

Upwork job is here. Can everyone send along proposals and I'll get the contract/payout covered.

[dhanashree-sawant]

Hi @JmillsExpensify, if possible, can you send me invite to the job?

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: [No QA] create UserMentionRenderer for rendering mentions inside chat #18495

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18495/files#r1246716190

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is simply a visual bug, I don't think there are additional steps we could take

• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? No
  Is it an impactful bug? No
  Bug has an extremely low impact, so I don't think a regression test is necessary here

[eVoloshchak]

Contributor+: @eVoloshchak $1,000

@JmillsExpensify, this has caused two regressions, so my pay should be reduced to 25%.
Not sure what the rules concerning this for Contributors are

Upwork job is here. Can everyone send along proposals and I'll get the contract/payout covered.

Could you hold my payment till tomorrow, please?
I'll try to request the payment using NewDot instead of Upwork, need some additional setting up to do

[JmillsExpensify]

Could you hold my payment till tomorrow, please?
I'll try to request the payment using NewDot instead of Upwork, need some additional setting up to do

Ok that'd be great. Will hold.

[JmillsExpensify]

@JmillsExpensify, this has caused two regressions, so my pay should be reduced to 25%. Not sure what the rules concerning this for Contributors are

At the moment, the deduction applies to C+.

[JmillsExpensify]

Bug has an extremely low impact, so I don't think a regression test is necessary here

I also agree with this.

[JmillsExpensify]

Offers sent to contributor and issue reporter.

[dhanashree-sawant]

Thanks I have accepted the offer.

[melvin-bot]

@JmillsExpensify, @eVoloshchak, @joelbettner, @tienifr Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

@eVoloshchak Did you request payment via New Expensify? Everyone else has been paid out at this point.

[eVoloshchak]

@JmillsExpensify, this has been paid out and can be closed

[joelbettner]

I'm going to close this issue.