-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Password Protected - keyboard is open but the cursor does not appear. #25739
Comments
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~013b0c0a37fb3237cb |
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
I can't reproduce the issue, I tried both in staging and production site with iPhone in Safari RPReplay_Final1692785370.MP4 |
📣 @hnihsan! 📣
|
@hnihsan i think you miss step 2 and did wrong step 6 |
Ohh, I see, my bad, let me try again |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Sorry still can't reproduce the issue @namhihi237 , or am I miss any step? RPReplay_Final1692786502.MP4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Password Protected - The keyboard is open but the cursor does not appear What is the root cause of that problem?https://github.com/Skalakid/App/blob/70000a49ea00e48e6c81c5184dc1d42d8f0cbff7/src/components/PDFView/PDFPasswordForm.js?#L70 What changes do you think we should make in order to solve the problem?so we need to set a timeout for delay focus so that we can avoid conflicts and we can give some time to blur complete
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Password Protected - keyboard is open but the cursor does not appear What is the root cause of that problem?In the useEffect we are setting the focus but not the selection position. When we swipe right the blur even it triggered and below line sends the focus back to the text box. But this doesn't set the position of the cursor
More details in this comment #25739 (comment) What changes do you think we should make in order to solve the problem?To solve the problem manually set the position of the cursor before focus. This is a workaround to make the cursor visible The following code does that
Result : iOS SafariiOS.Safari.movWhat alternative solutions did you explore? (Optional)Use
Detailed explanation here - #25739 (comment) |
@kameshwarnayak Why does it not set a cursor? |
@shubham1206agra https://stackoverflow.com/a/72465972 The explanation given in the comment is very similar to what happens here. The text input blurs and then because of the re-render the focus is set back causing the issue. The above comment helped to find the solution. |
@namhihi237 I don't think I understood the issue here. Can you please elaborate the issue? Is this the same issue? |
I have gone through the proposals as well. But none of them have good problem statement and root cause analysis. More details and well-explained RCA can lead to better solution. |
@sobitneupane That is a different issue that is more like a safari issue https://bugs.webkit.org/show_bug.cgi?id=195884 here when have more attachments we can navigate left or right in the preview. so at the time one of the attachments had a PDF with a password. that component will have an input box. when the input box is focused and starts to type something after that slightly moved to the next attachment it will go next and come back to the current input box. at the time the blur of focus happens keyboard is opened when we tab the input box but the cursor is hidden still, so we are able to enter text. |
Same as above |
@sobitneupane seems we haven't had any new proposals, so sounds like you're diving into the existing ones per this comment? |
If we don't get any new proposals by the weekend, I will delve into the existing ones |
@sobitneupane - Updated my proposal to add alternative solution using |
@sobitneupane, @greg-schroeder Eep! 4 days overdue now. Issues have feelings too... |
Looks like @sobitneupane will dive into this now that we've past the weekend! |
I'll be unavailable next week. If any action is needed, please feel free to reassign the task to another C+. |
@sobitneupane, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Okay I will re-assign! |
I think this is dupe of #10414 |
This is known iOS Safari issue |
@situchan this is a different and this issue is in mWeb/chrome only. the cursor is missing after opening a keyboard. |
Is this still reproducible? I see cursor when keyboard is open Screen.Recording.2023-10-18.at.1.33.11.AM.mov |
@sobitneupane, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@situchan - Looks like the bug is fixed in the latest master |
Still curious which PR fixed this |
Seems to be fixed, so closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Cursor appears when keyboard is open
Actual Result:
Cursor is not appears when keyboard is open
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.56-16
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1692005024.MP4
RPReplay_Final1692748714.mp4
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692005371991179
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: