[$1000] Workspace - Routing number field is not auto-focused, keyboard does not open

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-requisite: user must be logged in and have created a workspace

1. Tap on profile avatar in top right corner
2. Tap on "Workspaces"
3. Tap on any workspace
4. Tap on "Bank account"
5. Tap on "Connect manually"

Expected Result:

The routing number field should be auto-focused, the keyboard should open

Actual Result:

The routing number field is not auto-focused, keyboard does not open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6182896_Vhgd3420_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01480ef05d1047d901
• Upwork Job ID: 1698560092430299136
• Last Price Increase: 2023-09-22

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

Yup - I'm able to reproduce this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01480ef05d1047d901

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[napster125]

I can't reproduce it. Is there any specific step?

[maulikdhameliya]

This is iOS mweb specific issue, it works well on Android. I think there is PR for this #23922

[BhuvaneshPatil]

it happened on dektop web as well

[melvin-bot]

@sophiepintoraetz, @0xmiroslav Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@sophiepintoraetz, @0xmiroslav Still overdue 6 days?! Let's take care of this!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sophiepintoraetz]

Bump @0xmiroslav

[0xmiroslav]

@BhuvaneshPatil thanks for the proposal. We don't recommend shouldDelayFocus though it already exists in current codebase.

[0xmiroslav]

@BhuvaneshPatil thanks for the update.

We are passing shouldDelayFocus as false by default

This can't be the root cause

[melvin-bot]

@sophiepintoraetz @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[0xmiroslav]

still awaiting proposals with correct root cause and ideal solution

[0xmiroslav]

I am not able to reproduce on mSafari.
@lanitochka17 can you please test again?

[pradeepmdk]

@0xmiroslav This is a universal bug webkit by default without user interaction keyboard doesn't open. it will happen all the mWeb both chrome and safari.

https://bugs.webkit.org/show_bug.cgi?id=195884. both chrome and safari we will face this issue.

ref bug already opened
#10414

#25477

if we want we can verify here
https://codesandbox.io/s/react-focus-lock-forked-4q4f8c?file=/index.js
load this preview url in https://4q4f8c.csb.app/
but when safari app go background and again focused means keyboard will open

[b4s36t4]

Does this issue reproducible on simulator? I can't able to re-produce.

[0xmiroslav]

Not reproducible on simulator but physical device.

[melvin-bot]

@sophiepintoraetz, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sophiepintoraetz]

Ah, interesting - what do you make of this @0xmiroslav

[0xmiroslav]

There are number of similar issues where we should autofocus upon refresh. They are not closed.
Example: #27695

[sophiepintoraetz]

Hmm, we should collate all the issues and discuss in #open source then - do you have a couple of other issues as examples?

[0xmiroslav]

Auto-focus open issues I found so far: (and there maybe more)

• [HOLD for payment 2023-10-12] [$500] Web - Members page search bar does not get focused after removing and inviting a member #26955
• [$500] [Distance] - mWeb - Focus is missing on the input Distance. #27202
• [HOLD for payment 2023-10-27] [$500] Focus does not shift directly from "Manual" option to "Distance" option #27563
• [HOLD for payment 2023-10-16] [$500] Dev: Web - Room name field does not automatically focus when returning from the chat option #27607
• [$500] Chat - Emoji search is not in focus when tapping on emoji icon #27715
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Dev: Web - focus lose on click ctrl+shift+k again #27860
• [$500] iOS - Request Money - No autofocus blink cursor shown after navigating from Scan or Distance #28062
• [HOLD for payment 2023-10-10] [$500] Web - App doesn't re-focus on the text input when clicking on add split button #28070

In the past, there were lots of autofocus issues which were fixed or closed now.

• mWeb Safari - IOU - Cursor does not autofocus in Request money page #7064
• mWeb/Safari -Change password - Cursor does not autofocus Change password page #12439
• [HOLD for payment 2023-02-24] [$1000] Android -New Room- Keyboard do NOT open automatically when clicking New Room #15111
• [HOLD for payment 2023-05-16] [$1000] Request/Split/Send - There is NO cursor in the description input field #17579
• [HOLD for payment 2023-05-29] [$1000] ‘Message’ input field is not auto-focused even though it is the only input field in the page #18371
• [HOLD for payment 2023-05-23] [$1000] Assign Task - No focus on Description field in Assign task #18660
• autofocus not working if user open new task page using url #20000
• 2FA magic code input doesn't autofocus #20599
• Dev: The search field does not automatically focus when selecting a member for a money request #25803
• Web - After refreshing the page, the task title and description fields do not automatically focus #26139
• [$500] Dev: Web - Input fields are not auto focused on "Cash" page #26380
• mWeb - Workspaces - Search bar in invite members not focused after selecting an account #26488
• [$500] Request Money - The currency search field fails to auto-focus #27100
• [$500] Android - Payment input is not focused when tab changes from distance #27117
• [$500] Request money - Text input isn't auto focused after screen transition ends #27450
• ...

And they keep growing as time goes by.

[melvin-bot]

@sophiepintoraetz @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@sophiepintoraetz, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sophiepintoraetz]

Hmm, Carlos made a similar comment here that we cannot programmatically fix this - so this issue is likely to be closed - but will need to check why we're able to fix some and not others.

[sophiepintoraetz]

This can be moved to weekly while I am OOO next week.

[sophiepintoraetz]

Started the discussion here but will close this one.