Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] mWeb - App does not open keyboard on reload on share somewhere page #28550

Closed
1 of 6 tasks
kbecciv opened this issue Sep 30, 2023 · 37 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Sep 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Click on plus and click assign task
  3. Add any title and continue
  4. Click on share somewhere
  5. Reload and observe that app focuses on search but keyboard is not opened

Expected Result:

App should open keyboard on focus on search on share somewhere page

Actual Result:

App does not open keyboard on reload on share somewhere page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

android.chrome.reload.on.share.somewhere.page.no.keyboard.mp4
Screen_Recording_20230930_165634_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696015367950349

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012fb33f28776cfbe2
  • Upwork Job ID: 1708225036348899328
  • Last Price Increase: 2023-10-19
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 30, 2023
@melvin-bot melvin-bot bot changed the title mWeb - App does not open keyboard on reload on share somewhere page [$500] mWeb - App does not open keyboard on reload on share somewhere page Sep 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012fb33f28776cfbe2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@rayane-djouah
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a text input is focused and the page is reloaded, the app retains the focus on the text input, but the keyboard does not open.

What is the root cause of that problem?

The app retains the focus on the text input on refresh.

What changes do you think we should make in order to solve the problem?

In the BaseTextInput.js component, within the useEffect that handles autofocus, add a condition to blur the input if it's already focused, and then refocus it. This trigger the keyboard to show up.

if (isFocused) {
    input.current.blur();
}

What alternative solutions did you explore? (Optional)

@neg-0
Copy link
Contributor

neg-0 commented Oct 1, 2023

@rayane-djouah Where within the useEffect did you add the blur? I added it but it does not seem to have any effect on the text input.

@Krishna2323
Copy link
Contributor

@sophiepintoraetz @jjcoffee, I think it's similar to this one #26312 (comment)

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 2, 2023

@rayane-djouah Could you confirm if your fix works on mWeb Safari?

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@sophiepintoraetz
Copy link
Contributor

@dhanashree-sawant should have confirmed that this only happens on android, if that's the case, then I think it's not the same issue as #26312 (comment) because that's for iOS.

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@dhanashree-sawant
Copy link

Hi @sophiepintoraetz, sorry for the confusion, will ensure to mention that it is working fine on other platforms while raising the issue from now on.

@sophiepintoraetz sophiepintoraetz added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as duplicate.

@sophiepintoraetz
Copy link
Contributor

Hey @johncschuster! I just need some help babysitting this issue while I'm OOO till 17 Oct - so far, we only have one proposal for @jjcoffee to review. Otherwise, was going to bump in #open source / the agencies!

@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@johncschuster, @jjcoffee, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jjcoffee
Copy link
Contributor

@rayane-djouah Any response on this comment?

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@jjcoffee
Copy link
Contributor

The same happens on iOS Safari by the way:

ios-keyboard-2023-10-11_13.23.52.mp4

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@johncschuster
Copy link
Contributor

Posted in #expensify-open-source for proposals

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

@johncschuster @jjcoffee @sophiepintoraetz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@johncschuster
Copy link
Contributor

@sophiepintoraetz, I posted an announcement to gather more proposals, but it hasn't really gotten anywhere. Do you feel we should increase the bounty, or shall we wait a few more days?

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@mkhutornyi
Copy link
Contributor

I think this is mobile web's default behavior.
iOS Safari issue is known as in #10414

@dhanashree-sawant
Copy link

The following issue is specifically after reload, safari has that issue even on opening the page normally.

@sophiepintoraetz
Copy link
Contributor

Thank you for helping me out, @johncschuster - taking this back now.

@sophiepintoraetz sophiepintoraetz changed the title [$500] mWeb - App does not open keyboard on reload on share somewhere page [$1000] mWeb - App does not open keyboard on reload on share somewhere page Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Upwork job price has been updated to $1000

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

@jjcoffee @sophiepintoraetz this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@jjcoffee
Copy link
Contributor

Bumped on Slack.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@parasharrajat
Copy link
Member

parasharrajat commented Oct 23, 2023

This is a native behavior of the android chrome browser. I don't think we should be worried about this issue. We have close this many times in the past.

@jjcoffee
Copy link
Contributor

After testing based on our discussion on Slack, I can confirm there isn't really a fix for this as it requires user interaction first before we can programmatically open the keyboard. We're good to close this @sophiepintoraetz!

@abeebridwan
Copy link

abeebridwan commented Oct 23, 2023

I have been working on it for over two days.. I was able to blur and refocus.. however the keyboard didn't show... It seems the browser stopped from opening the keyboard without user's interaction

However there is navigator.virtualKeyboard which is only experimental but also only available on desktop

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

📣 @abeebridwan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@abeebridwan
Copy link

Contributor details
Your Expensify account email: olumideuae@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/ridwanabeeb2

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@sophiepintoraetz
Copy link
Contributor

Got it, thanks for the discussion all! Thank you @abeebridwan - looks like you just missed out - but there are plenty of issues for you to get involved with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests