Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-16] CRITICAL: [P2P Distance] [$1000] Opens to ocean on first load #40210

Closed
1 of 6 tasks
m-natarajan opened this issue Apr 13, 2024 · 69 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.62-5
Reproducible in staging?: y
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712974090053049

Action Performed:

  1. Tap green FAB for the first time on a new device
  2. Select track expense
  3. Select distance

Expected Result:

Should not show the location in the ocean

Actual Result:

Shows somewhere in the middle of the ocean

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

az_recorder_20240413_154538.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b4f219078951c444
  • Upwork Job ID: 1780696825171120128
  • Last Price Increase: 2024-04-26
  • Automatic offers:
    • Ollyws | Contributor | 0
    • wildan-m | Contributor | 0
Issue OwnerCurrent Issue Owner: @JmillsExpensify
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 13, 2024
Copy link

melvin-bot bot commented Apr 13, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan m-natarajan removed the Needs Reproduction Reproducible steps needed label Apr 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@quinthar
Copy link
Contributor

What is this issue waiting on? It's already been reproduced by me and Applause.

Copy link

melvin-bot bot commented Apr 16, 2024

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@quinthar
Copy link
Contributor

Bump; what are next steps @JmillsExpensify ?

@JmillsExpensify
Copy link

Ah missed this. Let me spin up an Android device in Browserstack to test.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@JmillsExpensify
Copy link

Hmm, I'm locked out of testing, so I'm going to add the external label so the community might re-produce the same.

@JmillsExpensify JmillsExpensify added the External Added to denote the issue can be worked on by a contributor label Apr 17, 2024
@melvin-bot melvin-bot bot changed the title CRITICAL: [P2P Distance] Opens to ocean on first load [$250] CRITICAL: [P2P Distance] Opens to ocean on first load Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b4f219078951c444

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@quinthar quinthar changed the title [$250] CRITICAL: [P2P Distance] Opens to ocean on first load CRITICAL: [P2P Distance] [$250] Opens to ocean on first load Apr 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2024
@quinthar
Copy link
Contributor

@c3024 can you give an ETA please? This is super urgent, thanks!

@mallenexpensify
Copy link
Contributor

@Ollyws , coming from here, you're able to reproduce and would like to be assigned, right? If so, please comment and I'll assign.

@mallenexpensify mallenexpensify changed the title CRITICAL: [P2P Distance] [$250] Opens to ocean on first load CRITICAL: [P2P Distance] [$500] Opens to ocean on first load Apr 22, 2024
@Ollyws
Copy link
Contributor

Ollyws commented Apr 22, 2024

Yeah go ahead thanks @mallenexpensify

Copy link

melvin-bot bot commented Apr 22, 2024

Upwork job price has been updated to $500

@mallenexpensify mallenexpensify assigned Ollyws and unassigned c3024 Apr 22, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
@wildan-m
Copy link
Contributor

wildan-m commented May 1, 2024

@quinthar ETA might be delayed due to a significant delay in receiving the magic code. The PR is heavily performs on re-login activities. The issue has been discussed in Slack and it appears that someone else is also experiencing the same problem.

@wildan-m
Copy link
Contributor

wildan-m commented May 1, 2024

@Ollyws Can you display the map on the web? It's not visible on my end, whether it's in development or staging.

image

@wildan-m
Copy link
Contributor

wildan-m commented May 1, 2024

@Ollyws ignore my earlier question, I found out that my chrome hardware acceleration setting was disabled (not sure why). Enabling it fixed the problem.

@wildan-m
Copy link
Contributor

wildan-m commented May 1, 2024

Apologies for the delay; I am currently addressing a compatibility issue with the pods and working to find the best solution.

@Ollyws did you experience the same thing in native iOS, or is it just me?

@Ollyws
Copy link
Contributor

Ollyws commented May 1, 2024

@wildan-m iOS was working fine for me when I tested.

@wildan-m
Copy link
Contributor

wildan-m commented May 2, 2024

@Ollyws may I know your processor type? is it apple silicon (M1,M2...) or intel?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 2, 2024
@wildan-m
Copy link
Contributor

wildan-m commented May 2, 2024

@Ollyws the PR for review is ready.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 3, 2024
@wildan-m
Copy link
Contributor

@luacmartins The PR was deployed to production last week, however it appears that the automation is not functioning correctly.

@luacmartins luacmartins changed the title CRITICAL: [P2P Distance] [$1000] Opens to ocean on first load [HOLD for payment 2024-05-16] CRITICAL: [P2P Distance] [$1000] Opens to ocean on first load May 15, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels May 15, 2024
@luacmartins
Copy link
Contributor

Updated the OP and labels.

@wildan-m
Copy link
Contributor

@luacmartins @JmillsExpensify friendly bump

@JmillsExpensify
Copy link

Payment summary:

Contributor: @wildan-m $1,000
Contributor: @Ollyws $1,000

@Ollyws Do you mind recommending the right regression test to ensure that this doesn't happen again?

@JmillsExpensify
Copy link

@wildan-m paid out.

@Ollyws
Copy link
Contributor

Ollyws commented May 21, 2024

Regression Test Proposal

1. Launch a clean install of the app and log in
2. Tap FAB > Submit Expense
3. Tap on the Distance tab
4. If the app prompts for permission, tap on Don't Allow
5. Verify the location is loaded at the default coordinates for the app [-122.4021, 37.7911] in San Francisco

Do we agree 👍 or 👎

@Ollyws
Copy link
Contributor

Ollyws commented May 21, 2024

Requested payment in ND. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 21, 2024
@mallenexpensify
Copy link
Contributor

Created the TestRail GH

@JmillsExpensify when you post the payment details can you inc. when a contributor is paid via Upwork or Newdot? Thx. (I'm not sure how helpful that is for you but, once we scale NewDot payments, it'll make it easier to know who's due payment via NewDot)

@JmillsExpensify
Copy link

@mallenexpensify will do! Not strictly need for me. While you're here though, I need someone else to approve my summary above. Can you confirm it's accurate?

@mallenexpensify
Copy link
Contributor

Contributor: @wildan-m paid $1,000 via Upwork
Contributor: @Ollyws owed $1,000 via NewDot

@JmillsExpensify
Copy link

$1,000 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests