Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash/underscore/Jquery from ExpensiMark #42494

Closed
puneetlath opened this issue May 22, 2024 · 14 comments
Closed

Remove lodash/underscore/Jquery from ExpensiMark #42494

puneetlath opened this issue May 22, 2024 · 14 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

In order to support Expensify/react-native-live-markdown#317 we need to remove external libs from ExpensiMark. This was discussed in Slack here.

@puneetlath puneetlath added the NewFeature Something to build that is a new item. label May 22, 2024
@puneetlath puneetlath self-assigned this May 22, 2024
Copy link

melvin-bot bot commented May 22, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Weekly KSv2 label May 22, 2024
Copy link

melvin-bot bot commented May 22, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented May 22, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@puneetlath
Copy link
Contributor Author

We don't need you here @dannymcclain 😄

@Skalakid
Copy link
Contributor

Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue

@hungvu193
Copy link
Contributor

Since I reviewed the linked PR, can you please assign me to this issue? @puneetlath
Thank you 😄

@puneetlath
Copy link
Contributor Author

Do we need to do anything else here? Do we need to update the app to use this version of expensify-common?

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@tomekzaw
Copy link
Contributor

Glad to announce that Expensify/expensify-common#718 has been merged and released in 2.0.15

Also, react-native-live-markdown uses expensify-common@2.0.19 (link).

Looks like we can mark this issue as complete.

@puneetlath
Copy link
Contributor Author

Ok great. Do we need to update the App in any way?

Looks like the only thing left then will be to pay out @hungvu193.

@hungvu193
Copy link
Contributor

@puneetlath Can you add BZ member so they can handle payment here? Thank you 😄

@puneetlath
Copy link
Contributor Author

Payment summary:

Please request on NewDot. Thanks everyone!

@hungvu193
Copy link
Contributor

Payment summary:

Please request on NewDot. Thanks everyone!

Thank you. Cortney is helping me setting up NewDot payment. I'll request once it's ready 🚀

@BartoszGrajdek BartoszGrajdek moved this from CRITICAL to Done in Live Markdown Jul 1, 2024
@hungvu193
Copy link
Contributor

hungvu193 commented Jul 2, 2024

Requested on NewDot 😄

@JmillsExpensify
Copy link

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

6 participants