Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Profile - Zoom slider does not change position when moving to zoom an image #45164

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 10, 2024 · 62 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gatantm+528@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #44788

Action Performed:

  1. Navigate to account Settings > Profile
  2. Click on the avatar
  3. Click on upload photo and upload any JPEG image
  4. Hover over the zoom slider and move to the right

Expected Result:

The zoom slider is moving to show how an image is zoomed

Actual Result:

The zoom slider stays on the same position when moving it to zoom uploaded image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537954_1720620814979.Recording__964.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0130ac939be52a2a80
  • Upwork Job ID: 1811335809081764317
  • Last Price Increase: 2024-09-19
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@Julesssss
Copy link
Contributor

Cute cat.

This needs to be fixed, but I'm demoting it from being a blocker.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Jul 10, 2024
@Julesssss
Copy link
Contributor

My best guess so far is that this PR introduced the bug

@ishpaul777
Copy link
Contributor

I can reproduce the issue even after reverting #44788

@Julesssss
Copy link
Contributor

Thanks for looking

@Julesssss Julesssss added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. labels Jul 11, 2024
@melvin-bot melvin-bot bot changed the title Profile - Zoom slider does not change position when moving to zoom an image [$250] Profile - Zoom slider does not change position when moving to zoom an image Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0130ac939be52a2a80

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

Copy link

melvin-bot bot commented Jul 11, 2024

📣 @harshit078! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@QichenZhu
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The zoom slider doesn't work.

What is the root cause of that problem?

In versions below 2.16.0, react-native-gesture-handler registers pointermove listeners but never unregisters them. This causes issues in development mode since StrictMode renders components twice. This has been fixed by software-mansion/react-native-gesture-handler#2815.

What changes do you think we should make in order to solve the problem?

  1. Wait until [HOLD for payment 2024-07-24] [$250] Profile - App crashes when uploading profile picture #45162 is resolved. Currently I'm using the work-in-progress solution from Make Slider Transformation Function Callback a worklet #45314.
  2. Upgrade react-native-gesture-handler to version 2.16.0 or newer.

What alternative solutions did you explore? (Optional)

N/A

@alexpensify
Copy link
Contributor

Weekly Update: #40548

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

This issue has not been updated in over 15 days. @alexpensify, @Julesssss, @hungvu193 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@alexpensify
Copy link
Contributor

Weekly update: The other GH we have been tracking states - Closing this in favor of the 0.75 upgrade

I need to figure out what we should do here. @roryabraham any feedback? Thanks!

@roryabraham
Copy link
Contributor

Should HOLD on #37374 instead

@roryabraham roryabraham changed the title [HOLD E/App #40548] [$250] Profile - Zoom slider does not change position when moving to zoom an image [HOLD E/App #37374] [$250] Profile - Zoom slider does not change position when moving to zoom an image Aug 25, 2024
@alexpensify
Copy link
Contributor

Weekly Update: Thanks, Rory! Still on hold for #37374

@roryabraham roryabraham changed the title [HOLD E/App #37374] [$250] Profile - Zoom slider does not change position when moving to zoom an image [$250] Profile - Zoom slider does not change position when moving to zoom an image Sep 4, 2024
@roryabraham
Copy link
Contributor

We are on RN 0.75 now, so I think this can come off hold. That issue isn't closed yet but is in the cleanup phase.

@roryabraham roryabraham added Weekly KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Sep 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2024
@alexpensify
Copy link
Contributor

Thank you, @roryabraham, for the update. @hungvu193 please keep us posted if you agree with this plan. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@hungvu193
Copy link
Contributor

Agreed!

@hungvu193
Copy link
Contributor

@alexpensify I think this is fixed on latest main, can you re-test this issue?

Screen.Recording.2024-09-05.at.16.02.33.mov

Copy link

melvin-bot bot commented Sep 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@alexpensify alexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Sep 6, 2024
@alexpensify
Copy link
Contributor

@lanitochka17 can your team please retest to confirm if there is still an issue? Thanks!

@alexpensify alexpensify added the Needs Reproduction Reproducible steps needed label Sep 6, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@alexpensify
Copy link
Contributor

Weekly update: waiting on a retest

Copy link

melvin-bot bot commented Sep 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@alexpensify
Copy link
Contributor

Weekly Update: I'll need to ask in Slack soon if no movement here.

Copy link

melvin-bot bot commented Sep 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@alexpensify
Copy link
Contributor

Closing - this is confirmed in the recent test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests