Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories & Tags - Not here page opens from GL code row #45429

Closed
6 tasks done
lanitochka17 opened this issue Jul 15, 2024 · 9 comments
Closed
6 tasks done

Categories & Tags - Not here page opens from GL code row #45429

lanitochka17 opened this issue Jul 15, 2024 · 9 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43149

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Collect workspace settings > Categories
  3. Click on any category
  4. Click GL code

Expected Result:

GL code editor will open

Actual Result:

Not here page opens.
The same issue also happens with tags

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543217_1721078508096.GL.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@rushatgabhane
Copy link
Member

@lanitochka17 is that a collect workspace?

@marcaaron
Copy link
Contributor

@rushatgabhane any ideas on this one?

@marcaaron
Copy link
Contributor

marcaaron commented Jul 16, 2024

My first guess would be it's related to #43149 gonna assign @Gonals since they are leading this up and QA has just started to run regressions.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jul 16, 2024

@marcaaron yes this is happening because the user is allowed to visit the page only if it is a collect workspace

@rushatgabhane
Copy link
Member

Not a blocker in my opinion. It will be replaced by Upgrade flow by @allroundexperts

@Gonals Gonals removed the DeployBlockerCash This issue or pull request should block deployment label Jul 16, 2024
@Gonals
Copy link
Contributor

Gonals commented Jul 16, 2024

Yep, not. blocker and not a bug. This is currently expected in non-control

@Gonals Gonals closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants