Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] Expensify Card - Reconciliation account link directs to hmm not here page #46108

Closed
3 of 6 tasks
m-natarajan opened this issue Jul 24, 2024 · 25 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.11
Reproducible in staging?: y
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/home

  2. Tap profile icon -- workspaces - workspace

  3. Tap more features - enable expensify card
    4 Tap expensify card
    5.Tap settings -- settlement account
    6.Tap Reconciliation account link

Expected Result:

Reconciliation account link must not direct to hmm not here page

Actual Result:

Reconciliation account link directs to hmm not here page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6550970_1721767597287.Screenrecorder-2024-07-24-02-10-55-695_compress_1.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 24, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@dangrous
Copy link
Contributor

Looks like a new page created in #45415 - pinging @koko57 @allgandalf @mountiny @MariaHCD

@allgandalf
Copy link
Contributor

This is still under beta, we can remove the blocker here

@koko57
Copy link
Contributor

koko57 commented Jul 24, 2024

Not a deploy blocker, we're still working on this project

@dangrous
Copy link
Contributor

ah okay great! I'll remove the labels

@dangrous dangrous added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jul 24, 2024
@allgandalf
Copy link
Contributor

ohh actually this shouldn't be a bug at all, we currently also set isUsedContinuousReconciliation to true we will update this when we have the BE onyx ready:
Screenshot 2024-07-24 at 8 18 35 PM

@dangrous
Copy link
Contributor

do you want me to assign y'all to this or will you handle as part of the implementation issues?

@mountiny mountiny assigned mountiny and unassigned dangrous Jul 24, 2024
@mountiny
Copy link
Contributor

Happy to take over to handle this

@allgandalf
Copy link
Contributor

I feel we can close this altogether, we really just want to uncomment the isUsedContinuousReconcilation and this will be resolved, don't want to keep K2 filled, what do you think @mountiny

@mountiny mountiny changed the title Expensify Card - Reconciliation account link directs to hmm not here page [Workspace Feeds] Expensify Card - Reconciliation account link directs to hmm not here page Jul 24, 2024
@trjExpensify
Copy link
Contributor

Do we need this issue then, @mountiny?

@mountiny
Copy link
Contributor

@allgandalf I will make it weekly but I think its better to have this reminder than the comment in code

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jul 25, 2024
@allgandalf
Copy link
Contributor

yeah, I'll make sure we address this issue

@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
@adelekennedy adelekennedy removed their assignment Aug 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2024
@allgandalf
Copy link
Contributor

@koko57 is this ready to be worked on ? are we still waiting on BE?

@koko57
Copy link
Contributor

koko57 commented Aug 7, 2024

Still waiting fot the BE

@trjExpensify
Copy link
Contributor

What command are you waiting on? Is it ToggleCardContinuousReconcilation?

@koko57
Copy link
Contributor

koko57 commented Aug 7, 2024

yup!

Copy link

melvin-bot bot commented Aug 7, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@koko57
Copy link
Contributor

koko57 commented Aug 7, 2024

After merging this PR #46978 this issue won't be reproducible

Copy link

melvin-bot bot commented Aug 7, 2024

@koko57 @mountiny @allgandalf this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@koko57
Copy link
Contributor

koko57 commented Aug 8, 2024

#46978 is merged, it can be retested now

@mountiny
Copy link
Contributor

mountiny commented Aug 8, 2024

@m-natarajan can you please retest this in staging?

@allgandalf
Copy link
Contributor

Lets test and close this one @m-natarajan

@mountiny
Copy link
Contributor

Closing as this should be fixed now, we can revisit if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

7 participants