Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS / Android - Screen will scroll on new messages when they are out of view #4754

Closed
kavimuru opened this issue Aug 19, 2021 · 18 comments
Closed

Comments

@kavimuru
Copy link

kavimuru commented Aug 19, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #4603

Action Performed:

  1. Open app and login
  2. Tap on any chat
  3. Scroll up 6-8 messages so new ones aren't seen
  4. On the other side, send new messages repeatedly on this same chat

Expected Result:

Messages will arrive and user can keep looking at the current ones

Actual Result:

Messages list will always scroll with new messages, even if user is viewing past history messages

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.0.86-2
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5197767_scroll.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 19, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title iOS -Chat - Screen will scroll on new messages even if they are out of view iOS / Android - Screen will scroll on new messages even if they are out of view Aug 20, 2021
@isagoico isagoico changed the title iOS / Android - Screen will scroll on new messages even if they are out of view iOS / Android - Screen will scroll on new messages when they are out of view Aug 20, 2021
@bondydaa
Copy link
Contributor

oh sorry I'm 100% focused on another task, unassigning for the pool

@bondydaa bondydaa removed their assignment Aug 20, 2021
@aldo-expensify
Copy link
Contributor

I understand that we may replace the component in the future (external library?) that we use to display comments in reports: https://github.com/Expensify/Expensify/issues/162811

Do we still want to fix this? Maybe it will just go away with the new implementation.

@aldo-expensify aldo-expensify added Weekly KSv2 and removed Hourly KSv2 labels Aug 23, 2021
@aldo-expensify aldo-expensify self-assigned this Aug 23, 2021
@aldo-expensify aldo-expensify removed the DeployBlockerCash This issue or pull request should block deployment label Aug 23, 2021
@aldo-expensify
Copy link
Contributor

Removing DeployBlockerCash: Tested this in production/Android and the problem is also there.

@aldo-expensify
Copy link
Contributor

Dropping this for now.

@aldo-expensify aldo-expensify removed their assignment Aug 23, 2021
@isagoico
Copy link

Issue reproducible during KI retests

1 similar comment
@isagoico
Copy link

isagoico commented Sep 5, 2021

Issue reproducible during KI retests

@isagoico
Copy link

Issue reproducible during KI retests.

@MelvinBot MelvinBot added Monthly KSv2 and removed Weekly KSv2 labels Sep 16, 2021
@MelvinBot
Copy link

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@MelvinBot MelvinBot removed the Overdue label Sep 16, 2021
@isagoico
Copy link

Issue reproducible during KI retests.

1 similar comment
@isagoico
Copy link

Issue reproducible during KI retests.

@isagoico
Copy link

isagoico commented Oct 4, 2021

Issue reproducible during KI retests.

2 similar comments
@mvtglobally
Copy link

Issue reproducible during KI retests.

@mvtglobally
Copy link

Issue reproducible during KI retests.

@mvtglobally
Copy link

Issue reproducible during KI retests.

1 similar comment
@mvtglobally
Copy link

Issue reproducible during KI retests.

@MelvinBot
Copy link

@kavimuru, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants