Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clean up] Update the OpenPaymentsPage command to return bank details and card details from Auth #47944

Open
mountiny opened this issue Aug 23, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

Problem

We are massaging the response data for the OpenPaymentsPage in Web. We end up sending the card details and bank account details in a different format than in other Auth commands, which leads to confusion. Example is here #47239 where the allowDebit, bank account type and accountNumber were missing in response from the AcceptACHContractForBankAccount command

### Solution

Start returning the card and bank account details for OpenPaymentsPage from Auth so we can use the same methods as we do in other commands like in OpenCardDetailsPage

@mountiny mountiny added Monthly KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Aug 23, 2024
@mountiny mountiny self-assigned this Aug 23, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor Author

mountiny commented Sep 2, 2024

This is just a polish

@melvin-bot melvin-bot bot removed the Overdue label Sep 2, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

@mountiny @kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mountiny
Copy link
Contributor Author

mountiny commented Sep 9, 2024

Not focusin gon this yet as its just polish

@mountiny
Copy link
Contributor Author

Havent got around yet

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@nkuoch nkuoch assigned nkuoch and unassigned mountiny Sep 24, 2024
@nkuoch nkuoch added the Reviewing Has a PR in review label Sep 24, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

This issue has not been updated in over 15 days. @nkuoch, @kadiealexander eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 17, 2024
@mountiny
Copy link
Contributor Author

@nkuoch not sure now, but is this fully completed? Or do we have one PR left?

@nkuoch nkuoch removed the Reviewing Has a PR in review label Oct 18, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Oct 18, 2024

I need to do 1 last cleanup to remove the transition code. OOO this week. So will do it on tuesday

@mountiny
Copy link
Contributor Author

Thank you for clarifying

@nkuoch
Copy link
Contributor

nkuoch commented Oct 22, 2024

Ah no, I also need to migrate fundList, userWallet and cardList formatting auth side.

On it!

@mountiny
Copy link
Contributor Author

le legende

@nkuoch nkuoch added the Reviewing Has a PR in review label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
Development

No branches or pull requests

3 participants