[Workspace Chats for All] [CRITICAL] Setting the isPolicyExpenseChatEnabled NVP to true changes the subject line in the unread summary email used to notify about report comments on expense reports

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C07NMDKEFMH/p1727310166201139?thread_ts=1727295182.755669&cid=C07NMDKEFMH

Action Performed:

Note: it's important that the account does not have tryNewDot.classicRedirect.dismissed===false, as we're simulating that scenario. You also need access to emails of the accounts you test with to check the emails received.

1. Create an account on OldDot, choose the "10+" qualifier to avoid a redirect to NewDot and setting of the tryNewDot NVP.
2. Go to Settings > Workspaces > Group > New workspace > Control
3. Go to that workspace's settings page on OldDot
4. Open the JS console and paste in this snippet:

p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = true;
p.save();

5. Go to the Members tab and invite an employee to the workspace
6. Sign-in to OldDot as the employee and create an expense report
7. Submit the expense report
8. Comment on the expense report
9. Wait 10mins for the unread summary email to be received by the admin
10. Observe the subject line of the email for the expense report.

Expected Result:

The subject line should use the expense report title given to expense reports on OldDot:

Said differently, we only want to start using the NewDot expense report title when:

• The workspace has isPolicyExpenseChatEnabled===true
• The user receiving the report has tryNewDot.classicRedirect.dismissed===false

Actual Result:

The subject line changes to the one we use for unreads on NewDot expense reports:

Workaround:

N/A, report comments are still received. But we're readying to enable the workspace chats for all workspaces old and new with no-impact. If we don't fix this, we'll make a material change to this email notification for all customers when we do, despite not actively using NewDot.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

CC: @JmillsExpensify @puneetlath

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

We're going to want to put this in the #newdot-migration project, when that GH project is created.

[trjExpensify]

^^ CC: @muttmuure @CherylWalsh

[muttmuure]

Done

[trjExpensify]

^^ fat fingered

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

Not overdue, waiting for an engineer to pick it up!

[kadiealexander]

Same as above.

[melvin-bot]

@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kadiealexander]

Not overdue!

[melvin-bot]

@kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[lakchote]

Taking it.