-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace Chats for All] [CRITICAL] Setting the isPolicyExpenseChatEnabled
NVP to true
changes the subject line in the unread summary email used to notify about report comments on expense reports
#49777
Comments
Triggered auto assignment to @kevinksullivan ( |
We're going to want to put this in the #newdot-migration project, when that GH project is created. |
^^ CC: @muttmuure @CherylWalsh |
Done |
This comment was marked as resolved.
This comment was marked as resolved.
^^ fat fingered |
Triggered auto assignment to @kadiealexander ( |
@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue, waiting for an engineer to pick it up! |
Same as above. |
@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue! |
@kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Taking it. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C07NMDKEFMH/p1727310166201139?thread_ts=1727295182.755669&cid=C07NMDKEFMH
Action Performed:
Note: it's important that the account does not have
tryNewDot.classicRedirect.dismissed===false
, as we're simulating that scenario. You also need access to emails of the accounts you test with to check the emails received.Expected Result:
The subject line should use the expense report title given to expense reports on OldDot:
Said differently, we only want to start using the NewDot expense report title when:
isPolicyExpenseChatEnabled===true
tryNewDot.classicRedirect.dismissed===false
Actual Result:
The subject line changes to the one we use for unreads on NewDot expense reports:
Workaround:
N/A, report comments are still received. But we're readying to enable the workspace chats for all workspaces old and new with no-impact. If we don't fix this, we'll make a material change to this email notification for all customers when we do, despite not actively using NewDot.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
In-line above.
View all open jobs on GitHub
CC: @JmillsExpensify @puneetlath
The text was updated successfully, but these errors were encountered: