Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header text in test transaction step of VBA flow #6477

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@parasharrajat @mountiny PR is ready for review.

Details

Updated header text in test transaction step of VBA flow to Test transactions (Previously it was "Connect bank account")

Fixed Issues

$ #6315

Tests | QA Steps

  1. Create a workspace
  2. Go to Connect bank account page within the workspace editor
  3. Tap Connect manually and go through VBA steps
  4. Arrive at step 5 to enter validation amounts

QA Check: On this page it should show Test transactions in header (Previously it was "Connect bank account")

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots (EN)

Web

Web-En

Mobile Web

MobileWeb-En

Desktop

Desktop-En

iOS

iOS-En

Android

Android-En

Screenshots (ES)

Web

Web-Es

Mobile Web

MobileWeb-Es

Desktop

Desktop-Es

iOS

iOS-Es

Android

Android-Es

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner November 25, 2021 12:43
@MelvinBot MelvinBot requested review from mountiny and removed request for a team November 25, 2021 12:43
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing much to test. LGTM. Ready for merge @mountiny .

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mountiny
Copy link
Contributor

Sorry for the delay with merging, there was something wrong with the tests. Merging now, thank you for this change!

@mountiny mountiny merged commit d53a74d into Expensify:main Nov 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @mountiny in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants