iOS - Tapping settings button from room details crashes the app

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing the PR #7028

Action Performed:

1. Open app and login applausetester+0704sveta@applause.expensifail.com
2. Select any room
3. Tap on name of the room to view the details
4. Tap on Settings

Expected Result:

Settings page should open

Actual Result:

App crashes all the time

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Web - Mac safari - Blank page appear
• mweb - Blank page appears

Version Number: 1.1.29-2
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5404870_log_Settings_12.01.txt

https://user-images.githubusercontent.com/43996225/149233948-d5cb55a4-efaa-4598-9bb6-879c925b4a84.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Jag96]

cc @TomatoToaster looks like this was introduced in #7028, can you confirm this should be a blocker?

[TomatoToaster]

Yep thanks for the tag, I can work on this

[stitesExpensify]

Should anything related to rooms be a blocker? It's all behind a beta right?

[stitesExpensify]

Also while testing just now I found another bug for a new room because I didn't have an icon

Besides that though, I cannot reproduce this in safari

[Jag96]

Should anything related to rooms be a blocker? It's all behind a beta right?

If its behind a beta I agree it shouldn't be a blocker, removing the label

[TomatoToaster]

@stitesExpensify omg that screenshot is VERY helpful. I've been trying to recreate what I saw once which was that I wouldn't see the icons when I created the room. I think that's causing the crash. Works when you log back in but is like that the first time.

[TomatoToaster]

Got a draft that I think will address the icon issue.

[TomatoToaster]

Still working on the fix for this!

[neil-marcellini]

@TomatoToaster @Jag96 @stitesExpensify
Hey guys, while testing this PR I had a similar issue where just tapping on the name of a new room to view the details causes a crash. It happens on all platforms and it looks like the icons are the issue. Shall I update the issue to reflect this?

[TomatoToaster]

@neil-marcellini does it happen when you are the only member of the workspace? I'm working on a fix for that and I've got a PR for it, but I just want to confirm I might not be missing another case.

[neil-marcellini]

Yep it only happens when you are the only member of the workspace. Thanks!

[kbecciv]

@Jag96 @TomatoToaster @neil-marcellini When tester was executing the PR #7692, we still have crash when tap on Settings. Do we need a separate issue?

Recording.222.mp4

[TomatoToaster]

@kbecciv Yes this should be its own issue I think, but could you assign me when it is created? I can look into it.

[kbecciv]

@TomatoToaster assigned #7786