Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken list components on staging #4300

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Fix broken list components on staging #4300

merged 1 commit into from
Jul 29, 2021

Conversation

marcaaron
Copy link
Contributor

Details

Fixing regression caused by this PR

Fixed Issues

$ #4293

Tests

QA Steps

  1. Test flows using /search, /new-group, /new-chat etc
  2. Make sure they do not crash when opening.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Jul 29, 2021
@marcaaron marcaaron marked this pull request as ready for review July 29, 2021 15:24
@marcaaron marcaaron requested a review from a team as a code owner July 29, 2021 15:24
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team July 29, 2021 15:24
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron merged commit 53793a0 into main Jul 29, 2021
@marcaaron marcaaron deleted the marcaaron-fixOptionsList branch July 29, 2021 16:23
github-actions bot pushed a commit that referenced this pull request Jul 29, 2021
@marcaaron
Merge pull request #4300 from Expensify/marcaaron-fixOptionsList
47527f8 
Fix broken list components on staging

(cherry picked from commit 53793a0)
This was referenced Jul 29, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Closed
100 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Aug 6, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madmax330 madmax330 madmax330 approved these changes

@nkuoch nkuoch Awaiting requested review from nkuoch

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @madmax330