Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Selecting a language does not update in real time #4366

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

kidroca
Copy link
Contributor

@kidroca kidroca commented Aug 2, 2021

Details

This is a continuation PR that addresses a regression from #4253

Fixed Issues

$ #4352

Tests

  1. Go to preferences
  2. Select a different language

Texts in app should dynamically change to the selected language

QA Steps

Same as "Tests"

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Screen.Recording.2021-08-02.at.22.12.53.mov

Desktop

image

iOS

Screen.Recording.2021-08-02.at.22.00.49.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2021-08-02.18-56-33.mp4

@kidroca kidroca requested a review from a team as a code owner August 2, 2021 15:57
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team August 2, 2021 15:57
@kidroca
Copy link
Contributor Author

kidroca commented Aug 2, 2021

Pushed another commit to fix a code style issue: 777468d

This is ready for review

@iwiznia
Copy link
Contributor

iwiznia commented Aug 2, 2021

@kidroca why no tests in ios or web?

@kidroca
Copy link
Contributor Author

kidroca commented Aug 2, 2021

@kidroca why no tests in ios or web?

I think you mean "or desktop" I did test on web

I'm using a Windows desktop workstation. To run iOS or the Desktop app I need to
connect remotely to my macbook, pull changes then build and start the app.
And sometimes there are pod related problems

I've seen others skip it and it seemed fine for the current situation

@kidroca
Copy link
Contributor Author

kidroca commented Aug 2, 2021

@iwiznia
Updated with tests on all platforms


I had some trouble running the Desktop app, finally after replacing my .env config from .env.production it worked

@MariaHCD
Copy link
Contributor

MariaHCD commented Aug 3, 2021

The Cherry-Pick label warning is failing on this PR. This has been fixed here: #4370 So I believe you'll need to merge main onto your feature branch to get the check passing, @kidroca

@kidroca
Copy link
Contributor Author

kidroca commented Aug 3, 2021

Ok will merge in a bit. This will revoke approvals

@iwiznia
Copy link
Contributor

iwiznia commented Aug 3, 2021

No need to re-merge, the check was broken and we already merged some PRs like that, so merging.

@iwiznia iwiznia merged commit 7d842b9 into Expensify:main Aug 3, 2021
github-actions bot pushed a commit that referenced this pull request Aug 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2021

🚀 Cherry-picked to staging in version: 1.0.82-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants