Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the proposal flow to indicate GH should be checked first #6245

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Nov 5, 2021

No test, no QA, just a contributing guidelines change.

cc @Expensify/contributor-management @sidferreira

@iwiznia iwiznia requested a review from a team as a code owner November 5, 2021 16:33
@iwiznia iwiznia self-assigned this Nov 5, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team November 5, 2021 16:34
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelhaxhiu michaelhaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean!

CONTRIBUTING.md Outdated Show resolved Hide resolved
jasperhuangg
jasperhuangg previously approved these changes Nov 5, 2021
Co-authored-by: Sid Ferreira <143615+sidferreira@users.noreply.github.com>
@iwiznia
Copy link
Contributor Author

iwiznia commented Nov 11, 2021

Updated with the suggestions

@Jag96 Jag96 merged commit 8eeebb9 into main Nov 17, 2021
@Jag96 Jag96 deleted the iwiznia-patch-1 branch November 17, 2021 00:35
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants