Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication in Report.js #8104

Merged
merged 8 commits into from
Mar 15, 2022
Merged

Remove duplication in Report.js #8104

merged 8 commits into from
Mar 15, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Mar 11, 2022

Details

Pusher subscription logic in Report.js is pretty wild and lots of copy pasta is used. Cleaning this up a bit.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/201111

Tests

  1. Not much apart from regressions around various realtime features like report comments
  2. Verify that you are subscribed to the Pusher channels here

2022-03-11_07-50-12

  • Verify that no errors appear in the JS console

QA Steps

  1. None apart from regressions around various realtime features like report comments
  • Verify that no errors appear in the JS console

@marcaaron marcaaron self-assigned this Mar 11, 2022
@marcaaron marcaaron marked this pull request as ready for review March 11, 2022 20:05
@marcaaron marcaaron requested a review from a team as a code owner March 11, 2022 20:05
@MelvinBot MelvinBot requested review from timszot and removed request for a team March 11, 2022 20:05
@timszot timszot merged commit 7acbc16 into main Mar 15, 2022
@timszot timszot deleted the marcaaron-cleanupPusher branch March 15, 2022 16:52
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @timszot in version: 1.1.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants