Move Android build variables to env #9120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
TomatoToaster
and removed request for
a team
|
|
TomatoToaster
approved these changes
Jun 7, 2022
|
@AndrewGable feel free to merge this. Wanted to wait till you were online so you could verify the build went successfully yourself. |
roryabraham
approved these changes
Jun 7, 2022
|
Yes - Correct. I confirmed that they are not used in that step in the |
OSBotify
pushed a commit
that referenced
this pull request
Jun 7, 2022
Move Android build variables to env (cherry picked from commit a337f97)
OSBotify
added a commit
that referenced
this pull request
Jun 7, 2022
…9120 🍒 Cherry pick PR #9120 to staging 🍒
47 tasks
|
🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.73-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀
|
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Removes the Android keystore and key alias passwords to environment variables to lock things down 🔐
Keystore and key password were rotated internally ♻️
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/209628
Tests