Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix status bar color when a modal is open" #9284

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Jun 1, 2022

Reverts #9210 because of #9280 deployblocker

It is a straight revert so not posting the screenshots. Alex has confirmed locally it fixes the problem.

Fixed Issues

$ #9280

Tests

  1. Log in to NewDot with any account
  2. Go to a chat or create one if needed
  3. Hit the "+" button at the bottom left of the chat input, then select "Add attachment" and upload a picture
  4. Wait for the attachment to finish uploading
  5. Make sure the eader of attachment is not overlapping with phone icons

@mountiny mountiny requested a review from a team as a code owner June 1, 2022 22:32
@mountiny mountiny self-assigned this Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team June 1, 2022 22:32
@mountiny mountiny requested a review from luacmartins June 1, 2022 22:38
@luacmartins
Copy link
Contributor

Merging since it's a straight revert!

@luacmartins luacmartins merged commit 026e4cd into main Jun 1, 2022
@luacmartins luacmartins deleted the revert-9210-fix-status-bar branch June 1, 2022 22:49
@mountiny
Copy link
Contributor Author

mountiny commented Jun 1, 2022

Thanks!

OSBotify pushed a commit that referenced this pull request Jun 1, 2022
Revert "Fix status bar color when a modal is open"

(cherry picked from commit 026e4cd)
OSBotify added a commit that referenced this pull request Jun 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2022

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.70-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants