Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron-notarize and use new notary tool #9295

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Jun 2, 2022

Details

Updated electron-notarize which now uses an app password instead of account password, which should allow us to skip 2FA checks which were I believe causing notary errors.

Fixed Issues

$ #9277

Tests

  1. Merge this PR
  2. Verify the staging build is notarized correctly

@AndrewGable AndrewGable self-assigned this Jun 2, 2022
@AndrewGable AndrewGable marked this pull request as ready for review June 2, 2022 20:38
@AndrewGable AndrewGable requested a review from a team as a code owner June 2, 2022 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team June 2, 2022 20:39
@AndrewGable AndrewGable removed the request for review from joelbettner June 2, 2022 21:18
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

@roryabraham roryabraham merged commit 9c2ab34 into main Jun 2, 2022
@roryabraham roryabraham deleted the andrew-notarize-update branch June 2, 2022 21:20
OSBotify pushed a commit that referenced this pull request Jun 2, 2022
OSBotify added a commit that referenced this pull request Jun 2, 2022
@luacmartins
Copy link
Contributor

Hmm so it's failing with Error: HTTP status code: 403. Invalid or inaccessible developer team ID for the provided Apple ID. Ensure the Team ID is correct and that you are a member of that team. failedTask=build stackTrace=Error: Failed to notarize via notarytool.

Seems like the correct team ID is 368M544MTT?

@AndrewGable
Copy link
Contributor Author

Good idea, see #9299 !

@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.70-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants