Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try our other Team ID for notarizing the Desktop app #9299

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

AndrewGable
Copy link
Contributor

Details

The first attempt at notarizing the desktop app failed with the following logs:

  ⨯ Failed to notarize via notarytool
Error: HTTP status code: 403. Invalid or inaccessible developer team ID for the provided Apple ID. Ensure the Team ID is correct and that you are a member of that team.
  failedTask=build stackTrace=Error: Failed to notarize via notarytool
                                                                                                                                                                                                                    Error: HTTP status code: 403. Invalid or inaccessible developer team ID for the provided Apple ID. Ensure the Team ID is correct and that you are a member of that team.

Let's try using a different teamID that is actually listed as our Developer Portal Team ID as seen here: https://github.com/Expensify/App/blob/main/fastlane/Appfile#L5

Fixed Issues

$ #9295

Tests

  1. Merge PR
  2. Verify desktop signs and notarizes correctly

@AndrewGable AndrewGable self-assigned this Jun 2, 2022
@AndrewGable AndrewGable marked this pull request as ready for review June 2, 2022 21:51
@AndrewGable AndrewGable requested a review from a team as a code owner June 2, 2022 21:51
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team June 2, 2022 21:52
@roryabraham roryabraham merged commit 8efaafa into main Jun 2, 2022
@roryabraham roryabraham deleted the andrew-team-id branch June 2, 2022 21:56
@AndrewGable AndrewGable mentioned this pull request Jun 2, 2022
OSBotify pushed a commit that referenced this pull request Jun 2, 2022
OSBotify added a commit that referenced this pull request Jun 2, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.70-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants