Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types generator use constants for hardcoded empty strings #8

Open
seseloos opened this issue Dec 1, 2020 · 0 comments
Open

Types generator use constants for hardcoded empty strings #8

seseloos opened this issue Dec 1, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@seseloos
Copy link
Contributor

seseloos commented Dec 1, 2020

Replace empty string "" within generator/types_generator.go with constants that have proper names to improve the readability and understanding of the code.

See the following lines of generator/types_generator.go as an example.

} else {
typ, err := types.FromSimpleSchema("", &parameter.SimpleSchema, parameter.Required, &parameter.CommonValidations)
gen.validators.AddAll(typ.GetValidators())
return typ, err
}

Also see the suggestion of @donutloop in pull request #5 for further information.

@seseloos seseloos added the enhancement New feature or request label Dec 1, 2020
@seseloos seseloos self-assigned this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant