Update rate limit policy to set redis expiry inline with windowMs #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 135 135
Lines 3649 3649
=======================================
Hits 3257 3257
Misses 392 392
Continue to review full report at Codecov.
|
|
Good catch! Thanks a lot for this! |
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…ire-on-windowms Update rate limit policy to set redis expiry inline with windowMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis rate limiter expires by default at 60 seconds.
Dividing the
windowMsinto seconds and then passing it through to replace the defaultexpiry: 60will ensure you get correct rate limiting when storing counters in Redis.