Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ".return" is not a function of "db.del" #930

Merged
merged 1 commit into from Jul 13, 2019

Conversation

nvanheuverzwijn
Copy link
Contributor

Whenever the token expiration code run, this error pops up.

{"error":"server_error","error_description":"this.remove(...).return is not a function"}

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #930 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   88.91%   88.96%   +0.05%     
==========================================
  Files         137      137              
  Lines        3734     3735       +1     
==========================================
+ Hits         3320     3323       +3     
+ Misses        414      412       -2
Impacted Files Coverage Δ
...ices/authorization-codes/authorization-code.dao.js 95.45% <100%> (+4.97%) ⬆️
lib/policies/oauth2/oauth2-server.js 94.79% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f29dca...25e0b9a. Read the comment docs.

@XVincentX
Copy link
Member

Thanks @nvanheuverzwijn. It's really this part isn't properly tested; would you be open to add a minimal test for this functionality as well?

Whenever the token expiration code run, this error pops up.
```
{"error":"server_error","error_description":"this.remove(...).return is not a function"}
```
@nvanheuverzwijn
Copy link
Contributor Author

@XVincentX Just added a test. Tell me if this is what you have in mind.

@XVincentX
Copy link
Member

Thanks for this fix, I'll release a version now :)

@XVincentX XVincentX merged commit bfb000b into ExpressGateway:master Jul 13, 2019
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
fix: ".return" is not a function of "db.del"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants