Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2-Introspect plugin was always using the same passport strategy #942

Conversation

tagkiller
Copy link

OAuth2 Introspection was hitting always the latest endpoint configured, in whichever pipeline.
Please have a look at this for more info.
@XVincentX here is the related PR to the matter discussed in the above referenced link :-)

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #942 into master will increase coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   88.96%   88.97%   +<.01%     
==========================================
  Files         137      137              
  Lines        3735     3737       +2     
==========================================
+ Hits         3323     3325       +2     
  Misses        412      412
Impacted Files Coverage Δ
lib/policies/jwt/extractors.js 100% <ø> (ø) ⬆️
lib/policies/request-transformer/schema.js 100% <ø> (ø) ⬆️
bin/generators/credentials/create.js 89.47% <ø> (ø) ⬆️
lib/policies/oauth2/index.js 100% <ø> (ø) ⬆️
lib/plugin-installer.js 91.93% <ø> (ø) ⬆️
bin/generators/users/list.js 92.85% <ø> (ø) ⬆️
lib/services/consumers/application.dao.js 98.55% <100%> (ø) ⬆️
lib/policies/index.js 100% <100%> (ø) ⬆️
lib/policies/oauth2/oauth2.js 88.05% <100%> (ø) ⬆️
...ib/policies/oauth2-introspect/oauth2-introspect.js 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5864b02...452dccc. Read the comment docs.

Copy link
Member

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the long investigation. I've pushed the change for you and merging/releasing this.

lib/policies/oauth2-introspect/oauth2-introspect.js Outdated Show resolved Hide resolved
@XVincentX XVincentX force-pushed the fix/oauth2-introspect_multiple_pipelines branch from 1a3949b to 452dccc Compare September 7, 2019 11:17
@XVincentX XVincentX merged commit 45c812e into ExpressGateway:master Sep 7, 2019
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
…spect_multiple_pipelines

OAuth2-Introspect plugin was always using the same passport strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants