Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint script #38

Open
mattlub opened this issue Nov 29, 2018 · 2 comments
Open

lint script #38

mattlub opened this issue Nov 29, 2018 · 2 comments
Assignees

Comments

@mattlub
Copy link

mattlub commented Nov 29, 2018

"lint": "./node_modules/.bin/eslint ./src/server/**/*.js",

why does your lint script only look inside src/server?

@mhmdtshref
Copy link
Collaborator

That's because we've used the ES6 linter test, but as i know we shouldn't use ES6 on the front-end files, we should just use ES5 and that makes an linter errors.

@mattlub
Copy link
Author

mattlub commented Nov 29, 2018

yes, that's ok, but you should also lint the other folders in your src/ folder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants