Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete NewsItem, NewsItemListCell etc. #1759

Closed
1-alex98 opened this issue Jun 7, 2020 · 0 comments · Fixed by #1768
Closed

Delete NewsItem, NewsItemListCell etc. #1759

1-alex98 opened this issue Jun 7, 2020 · 0 comments · Fixed by #1768
Assignees
@Askaholic
Labels
beginner-friendly

Comments

@1-alex98
Copy link
Member

1-alex98 commented Jun 7, 2020 •
edited

After integratiing news hub there are news classes laying arround(unused) that should be deleted.

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt
@1-alex98 1-alex98 mentioned this issue Jun 7, 2020
Closed
@Brutus5000 Brutus5000 changed the title NewsItem, NewsItemListCell etc. should be delted Delete NewsItem, NewsItemListCell etc. Jun 7, 2020
@Askaholic Askaholic self-assigned this Jun 12, 2020
@Askaholic Askaholic mentioned this issue Jun 12, 2020
Merged
1-alex98 pushed a commit that referenced this issue Jun 12, 2020
@Askaholic
Delete unused news classes (#1768)
463dfaa 
Fixes #1759
krristi427 pushed a commit that referenced this issue Jun 28, 2020
@Askaholic @krristi427
Delete unused news classes (#1768)
ccf8506 
Fixes #1759
jofaul pushed a commit that referenced this issue Jul 12, 2020
@1-alex98 @jofaul
Changes from develop:
fdcd943 
Update install4j download link

Meaning full pagination css

Delete unused news classes (#1768)

Fixes #1759

Go back to java fx 11.02

Show panel if needed permission are given

Fixes #1524

turn show/hide details button in custom games into an icon

Fixes #1732

Fix readme main class (#1787)

Fixes #1785

Update messages_zh.properties (POEditor.com)

Update messages_cs.properties (POEditor.com)

Update messages_nl.properties (POEditor.com)

Update messages_fr.properties (POEditor.com)

Update messages_de.properties (POEditor.com)

Update messages_iw.properties (POEditor.com)

Update messages_pl.properties (POEditor.com)

Update messages_ru.properties (POEditor.com)

Update messages_es.properties (POEditor.com)

Update messages_tr.properties (POEditor.com)

Update messages_uk.properties (POEditor.com)

Don't show game join menu item when game mode is ladder

Fixes #936

Improve readme (#1796)

* Update readme.md to make small changes and make it look nicer

* Update readme.md add link to intellij idea

* Update readme.md

Fix tag rendering issue

* Update readme.md

Use correct replay download url (fixes #1801) (#1802)

Create flowPane around menu buttons

Fixes #1209

Add methods for Meta Object

Add methods for Meta Object

Add methods for Meta Object

Add methods for Meta Object

Fix "None" map name retrieved for generated maps (#1788)

Fixes #1772

Co-authored-by: Sheikah45 <Sheikah450@gmail.com>

Be able to read JsonApiDocument class
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Askaholic
Delete unused news classes (FAForever#1768)
8e2ec28 
Fixes FAForever#1759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Askaholic Askaholic

Labels
beginner-friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete unused news classes Askaholic/downlords-faf-client
2 participants
@Askaholic @1-alex98