Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapGen: can't watch replay with generated map #1772

Closed
shalkya opened this issue Jun 14, 2020 · 3 comments · Fixed by #1788
Closed

MapGen: can't watch replay with generated map #1772

shalkya opened this issue Jun 14, 2020 · 3 comments · Fixed by #1788
Assignees
@Katharsas
Labels
bug S2 major severity 2 - major - major loss of function
Milestone
v1.1.9

Comments

@shalkya
Copy link
Member

shalkya commented Jun 14, 2020

image
you get this error. From what geo said, this isn't a bug related to map generator, but to the client.

Geosearchef: The map generator is deterministic, given a seed
Geosearchef: It detects and auto downloads the required version based on the map name
@shalkya shalkya added the bug label Jun 14, 2020
@1-alex98
Copy link
Member

yes might still be map gen bug... gimme log of the client

@Katharsas Katharsas changed the title can't watch replay with generated map MapGen: can't watch replay with generated map Jun 18, 2020
@Katharsas Katharsas added the S2 major severity 2 - major - major loss of function label Jun 19, 2020
@Katharsas
Copy link
Collaborator

Katharsas commented Jun 19, 2020 •
edited

@axel1200 how can it be a map gen bug?? The mapgen doesnt do anything with replays.

Btw this is trivial to reproduce. Just start a map gen game, go to online replay vault, your replays, try to watch it.
The problem seems to be that the client just looks at the replay json metadata, which contains "mapname": "None", and then throws the error because there is no map. Seems like map name is not correctly saved in replays.

I checked in API, map name is nowhere to be found. The client saves the mapName correctly in local replay files. Maybe a replay server problem?

@Katharsas Katharsas self-assigned this Jun 19, 2020
@Katharsas
Copy link
Collaborator

Katharsas commented Jun 19, 2020 •
edited

Ok there are multiple problems here:

  • The replay server saves "None" into the map name because it sets the map name by finding map filename and getting map name based on that from DB, but DB does not have mapgen maps. This can be fixed by the client reading the mapname directly from the replay instead of the metadata, like it already does for coop maps.
  • I am an idiot.

Additionally:
The MapService currently always regenerates mapgen maps instead of checking if they already exist like normal maps and then skipping generation.

@Katharsas Katharsas mentioned this issue Jun 20, 2020
Merged
1-alex98 pushed a commit that referenced this issue Jul 5, 2020
@Katharsas @Sheikah45
Fix "None" map name retrieved for generated maps (#1788)
ea3578a 
Fixes #1772

Co-authored-by: Sheikah45 <Sheikah450@gmail.com>
jofaul pushed a commit that referenced this issue Jul 12, 2020
@1-alex98 @jofaul
Changes from develop:
fdcd943 
Update install4j download link

Meaning full pagination css

Delete unused news classes (#1768)

Fixes #1759

Go back to java fx 11.02

Show panel if needed permission are given

Fixes #1524

turn show/hide details button in custom games into an icon

Fixes #1732

Fix readme main class (#1787)

Fixes #1785

Update messages_zh.properties (POEditor.com)

Update messages_cs.properties (POEditor.com)

Update messages_nl.properties (POEditor.com)

Update messages_fr.properties (POEditor.com)

Update messages_de.properties (POEditor.com)

Update messages_iw.properties (POEditor.com)

Update messages_pl.properties (POEditor.com)

Update messages_ru.properties (POEditor.com)

Update messages_es.properties (POEditor.com)

Update messages_tr.properties (POEditor.com)

Update messages_uk.properties (POEditor.com)

Don't show game join menu item when game mode is ladder

Fixes #936

Improve readme (#1796)

* Update readme.md to make small changes and make it look nicer

* Update readme.md add link to intellij idea

* Update readme.md

Fix tag rendering issue

* Update readme.md

Use correct replay download url (fixes #1801) (#1802)

Create flowPane around menu buttons

Fixes #1209

Add methods for Meta Object

Add methods for Meta Object

Add methods for Meta Object

Add methods for Meta Object

Fix "None" map name retrieved for generated maps (#1788)

Fixes #1772

Co-authored-by: Sheikah45 <Sheikah450@gmail.com>

Be able to read JsonApiDocument class
@1-alex98 1-alex98 added this to the v1.1.9 milestone Jul 21, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Katharsas @Sheikah45
Fix "None" map name retrieved for generated maps (FAForever#1788)
b161ef2 
Fixes FAForever#1772

Co-authored-by: Sheikah45 <Sheikah450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Katharsas Katharsas

Labels
bug S2 major severity 2 - major - major loss of function
Projects
None yet
Milestone
v1.1.9
Development

Successfully merging a pull request may close this issue.

Fix "None" map name retrieved for generated maps FAForever/downlords-faf-client
3 participants
@Katharsas @shalkya @1-alex98