Fix "None" map name retrieved for generated maps #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1-alex98
requested changes
Jun 20, 2020
|
CI failing |
|
@Sheikah45 thanks for improving this, looking good imo. |
Sheikah45
previously approved these changes
Jul 1, 2020
For some reason parseMapFolderName returns the map name without any capitalization from the raw replay bytes. This causes issues with the base64 string encoding used by the next gen map generator. parseMapName returns the map name with correct capitalization making it more suitable for usage. As an aside it appears that parseMapFolderName uses the scenario file in the raw bytes to get the map name whereas parseMapName uses the .scmap file and the capitalization differences are reflected there.
Sheikah45
previously approved these changes
Jul 2, 2020
Sheikah45
approved these changes
Jul 2, 2020
1-alex98
approved these changes
Jul 5, 2020
jofaul
pushed a commit
that referenced
this pull request
Jul 12, 2020
Update install4j download link Meaning full pagination css Delete unused news classes (#1768) Fixes #1759 Go back to java fx 11.02 Show panel if needed permission are given Fixes #1524 turn show/hide details button in custom games into an icon Fixes #1732 Fix readme main class (#1787) Fixes #1785 Update messages_zh.properties (POEditor.com) Update messages_cs.properties (POEditor.com) Update messages_nl.properties (POEditor.com) Update messages_fr.properties (POEditor.com) Update messages_de.properties (POEditor.com) Update messages_iw.properties (POEditor.com) Update messages_pl.properties (POEditor.com) Update messages_ru.properties (POEditor.com) Update messages_es.properties (POEditor.com) Update messages_tr.properties (POEditor.com) Update messages_uk.properties (POEditor.com) Don't show game join menu item when game mode is ladder Fixes #936 Improve readme (#1796) * Update readme.md to make small changes and make it look nicer * Update readme.md add link to intellij idea * Update readme.md Fix tag rendering issue * Update readme.md Use correct replay download url (fixes #1801) (#1802) Create flowPane around menu buttons Fixes #1209 Add methods for Meta Object Add methods for Meta Object Add methods for Meta Object Add methods for Meta Object Fix "None" map name retrieved for generated maps (#1788) Fixes #1772 Co-authored-by: Sheikah45 <Sheikah450@gmail.com> Be able to read JsonApiDocument class
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this pull request
Apr 15, 2022
Fixes FAForever#1772 Co-authored-by: Sheikah45 <Sheikah450@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1772